Skip to content

Commit 253b716

Browse files
committed
Have wasm job fail the workflow but not block auto-merge
The WebAssembly CI job definition had an unconditional job-level `continue-on-error` set to `true`, so that it would always report a successful conclusion, even on failure. This made sense before PR auto-merge was set up. But these jobs do not typically fail, and their failures should be more apparent, even if they should not yet block PRs from being auto-merged. This commit changes the `wasm` jobs so they are able to fail and cause the workflow as a whole to have a failing status, while still not blocking PR auto-merge. `continue-on-error` is removed from the job definition, but it is also no longer made a dependency of the required `tests-pass` check.
1 parent 87670a6 commit 253b716

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

.github/workflows/ci.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,6 @@ jobs:
215215

216216
runs-on: ubuntu-latest
217217

218-
continue-on-error: true
219-
220218
strategy:
221219
matrix:
222220
target: [ wasm32-unknown-unknown, wasm32-wasi ]
@@ -302,6 +300,7 @@ jobs:
302300
# List all jobs that are intended NOT to block PR auto-merge here.
303301
EXPECTED_NONBLOCKING_JOBS: |-
304302
test-fixtures-windows
303+
wasm
305304
tests-pass
306305
307306
defaults:
@@ -338,7 +337,6 @@ jobs:
338337
- test-32bit
339338
- lint
340339
- cargo-deny
341-
- wasm
342340
- check-packetline
343341
- check-blocking
344342

0 commit comments

Comments
 (0)