fix submodule is nil panic (go-gitea#23588)

viletyy · delvh · KN4CK3R · GiteaBot · commit 1e11f59cb81d · 2023-03-20T22:26:41.000Z
go-gitea#23587 submodule path is nil It is panic a nil error --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
diff --git a/services/repository/files/content.go b/services/repository/files/content.go
@@ -214,7 +214,9 @@ func GetContents(ctx context.Context, repo *repo_model.Repository, treePath, ref
 		if err != nil {
 			return nil, err
 		}
-		contentsResponse.SubmoduleGitURL = &submodule.URL
+		if submodule != nil && submodule.URL != "" {
+			contentsResponse.SubmoduleGitURL = &submodule.URL
+		}
 	}
 	// Handle links
 	if entry.IsRegular() || entry.IsLink() {

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,9 @@ func GetContents(ctx context.Context, repo *repo_model.Repository, treePath, ref`
`214`	`214`	`if err != nil {`
`215`	`215`	`return nil, err`
`216`	`216`	`}`
`217`		`- contentsResponse.SubmoduleGitURL = &submodule.URL`
	`217`	`+ if submodule != nil && submodule.URL != "" {`
	`218`	`+ contentsResponse.SubmoduleGitURL = &submodule.URL`
	`219`	`+ }`
`218`	`220`	`}`
`219`	`221`	`// Handle links`
`220`	`222`	`if entry.IsRegular() \|\| entry.IsLink() {`