Skip to content

GitVersion cannot find remote master or develop from inherited branch config #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
threegerbils opened this issue Feb 26, 2019 · 1 comment
Labels
Milestone

Comments

@threegerbils
Copy link

threegerbils commented Feb 26, 2019

The most recent beta release changes the default branch regexes in a way that prevents them from matching remote branches if GitVersion can't find the parent.

var chosenBranch = repository.Branches.FirstOrDefault(b => Regex.IsMatch(b.FriendlyName, developBranchRegex, RegexOptions.IgnoreCase)

The use of Branch.FriendlyName with the default master regex of ^master$ means that it will never match a remote branch.

see also
#1410

@asbjornu
Copy link
Member

asbjornu commented Mar 1, 2019

@tvoyle: Thanks for the bug report and suggested fix. I've submitted #1613 that hopefully should fix the problem.

@arturcic arturcic added this to the 5.0.0 milestone Mar 1, 2019
@arturcic arturcic added the Bug label Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants