-
Notifications
You must be signed in to change notification settings - Fork 653
Remove Mono dependecy #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The latest beta packages should run under dotnet core sdk <= 2.0.0 now. If you have 2.1.0 installed youll need a global.json file to pin sdk version to 2.0.0 until we merge a Pr that adds support for > 2.0.0 |
We also have a dotnet core 2.0 based docker image. |
@dazinator Assuming you're talking about gittools/gitversion-dotnetcore:0.0.0-alpha0015 (The most recent tag for gittools/gitversion is over a year old) It would appear that image is windows based. Can we get a linux image with the dotnet core version? |
@nlowe I don't see why not. Is this something you would consider contributing? The docker files are pretty simple - you can see them here: https://github.com/GitTools/GitVersion/tree/master/src/Docker/ I assume you just want a copy of the dotnetcore one, just using the linux base image right? |
Sure. I'd be happy to contribute. Do you want a separate issue to track this, or can I just send in a PR? |
So It looks like |
I see. I think there is automation for the docker build and push, check this script: https://github.com/GitTools/GitVersion/blob/master/deploy.cake#L211 Perhaps you could look at adjusting that in a PR to cater for the linux version - you are right #1445 isnt fully sorted yet, but once it is, we should see some fruits of our labour. |
Getting the docker images deployed is high on my priority list, because it's what I use because all our build servers are centOS and can't run GitVersion at all |
Will probably sort out on Saturday |
@JakeGinnivan if I may, why can't one run GitVersion on CentOS? libgit2sharp.nativebinaries supports rhel RID. |
I had the issue quite some time ago @derwasp . But it was due to libssl or something from memory. Can try running natively again though! |
@JakeGinnivan I built an AWS lambda function, which runs on something very close to rhel.7.2-x64 and I am using gitversion lib in there. Works like charm. |
Has there been any progress made on this? |
@RouR could you have a look at the new docker images? you can find them here https://hub.docker.com/r/gittools/gitversion-dotnetcore/tags/ |
I don`t know how to use it directly in my project. This script will call gitversion and it will throw this error (See initial issue) |
I seems the nuke-build you're using depends on a version of GitVersion that runs on mono only https://github.com/nuke-build/nuke/blob/develop/source/Nuke.GlobalTool/templates/_build.sdk.csproj#L15. There is a PR in progress that adds support for .net core sdk 2.1 and global tools |
@arturcic Regarding the Global Tool, I noticed this on NuGet.org: https://www.nuget.org/packages/dotnet-gitversion/ Is that going to cause a problem? Or what were you thinking about naming the package? |
Btw related to that, probably we should consider reviewing the nuget packages IDs by making them shorter and add the GitTools as prefix to avoid confusions with other packages on nuget.org? As far as I can see this is not a global tool, meaning it will not cause issues when running the global tool |
probably we need to open an issue regarding the package IDs, and have the discussion there |
Sounds like a good idea to me. |
From this comment - If I want to use GitVersion, Mono must have installed.
I try to use it on Travic CI server ubuntu.14.04-x64 without any dependency to Mono, and it`s fail.
Is it really necessary to use Mono?
.NET Core 2.0.2 work`s fine on ubuntu.14.04-x64 without any dependency to Mono
The text was updated successfully, but these errors were encountered: