Skip to content

Commit 3293afc

Browse files
authored
Merge pull request #1470 from GitTools/issue-1458
fixes #1458 - msbuild null ref issue
2 parents 570d7ba + d0356ba commit 3293afc

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

src/GitVersionTask.Tests/GitVersionTask.Tests.csproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
44
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
@@ -54,6 +54,10 @@
5454
<PackageReference Include="Shouldly" Version="3.0.0"></PackageReference>
5555
<PackageReference Include="System.Reflection.Metadata" Version="1.4.2"></PackageReference>
5656
<PackageReference Include="System.Collections.Immutable" Version="1.3.1"></PackageReference>
57+
<!--See https://github.com/Microsoft/msbuild/issues/3671 for reason for the ExcludeAssets against msbuild packagerefernces -->
58+
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="15.1.548" />
59+
<PackageReference Include="Microsoft.Build.Framework" Version="15.1.548" />
60+
5761
</ItemGroup>
5862
<ItemGroup>
5963
<Reference Include="Microsoft.CSharp" />

src/GitVersionTask/GitVersionTask.csproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,9 @@
7979
<PackageReference Include="YamlDotNet" Version="$(PackageVersion_YamlDotNet)">
8080
<PrivateAssets>All</PrivateAssets>
8181
</PackageReference>
82-
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="15.1.548" />
83-
<PackageReference Include="Microsoft.Build.Framework" Version="15.1.548" />
82+
<!--See https://github.com/Microsoft/msbuild/issues/3671 for reason for the ExcludeAssets against msbuild packagerefernces -->
83+
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="15.1.548" ExcludeAssets="runtime" />
84+
<PackageReference Include="Microsoft.Build.Framework" Version="15.1.548" ExcludeAssets="runtime" />
8485
<PackageReference Include="UtilPack.NuGet.MSBuild" Version="$(PackageVersion_UtilPackNuGetMSBuild)" />
8586
</ItemGroup>
8687

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project>
22
<PropertyGroup>
3-
<PackageVersion_UtilPackNuGetMSBuild>2.6.0</PackageVersion_UtilPackNuGetMSBuild>
3+
<PackageVersion_UtilPackNuGetMSBuild>2.7.0</PackageVersion_UtilPackNuGetMSBuild>
44
</PropertyGroup>
55
</Project>
66

0 commit comments

Comments
 (0)