Skip to content

Migrate Travis CI jobs to GitHub Actions #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
seisman opened this issue Aug 18, 2020 · 4 comments · Fixed by #713
Closed
1 of 2 tasks

Migrate Travis CI jobs to GitHub Actions #566

seisman opened this issue Aug 18, 2020 · 4 comments · Fixed by #713
Labels
help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Aug 18, 2020

Description of the desired feature

We recently migrated all the CI testings and style checks from Azure Pipelines to GitHub Actions. Currently, we're using both GitHub Actions and Travis CI.

The Travis CI is doing following jobs:

The first one is already covered in the GitHub Actions, so it's OK to just remove them from Travis CI.

The 2nd and the 3rd one should be migrated to GitHub Actions.

Are you willing to help implement and maintain this feature? Yes, but contributions are welcome.

@seisman seisman added help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs labels Aug 18, 2020
@weiji14
Copy link
Member

weiji14 commented Aug 18, 2020

No strong objections to this, we should do all three in separate PRs. Only concern would be that this makes up totally dependent on Github, which might be problematic if GIthub servers go down (but that's a bigger issue in itself).

The first one is already covered in the GitHub Actions, so it's OK to just remove them from Travis CI.

Yep. Or we could keep one single test around. Maybe a test for a nightly Python build for the upcoming Python 3.9?

The 2nd and the 3rd one should be migrated to GitHub Actions.

On the 2nd one, see GenericMappingTools/website#65 as an example on documentation build/deploy.

For the 3rd one (Publish to PyPI), we could use https://github.com/marketplace/actions/pypi-publish, and maybe test it on https://test.pypi.org (instead of the main pypi.org website) first to be sure we don't break anything.

@seisman
Copy link
Member Author

seisman commented Aug 19, 2020

The first one is already covered in the GitHub Actions, so it's OK to just remove them from Travis CI.

Yep. Or we could keep one single test around. Maybe a test for a nightly Python build for the upcoming Python 3.9?

We rely on packages from conda-forge. If conda-forge doesn't provide numpy, pandas and xarray packages for Python 3.9, I don't think we can get the testings running.

The 2nd and the 3rd one should be migrated to GitHub Actions.

On the 2nd one, see GenericMappingTools/website#65 as an example on documentation build/deploy.

We still need the https://github.com/fatiando/continuous-integration/blob/master/travis/deploy-gh-pages.sh script, because documentation of different versions are stored in separated directories.

For the 3rd one (Publish to PyPI), we could use https://github.com/marketplace/actions/pypi-publish, and maybe test it on https://test.pypi.org (instead of the main pypi.org website) first to be sure we don't break anything.

To make it work, we may need a PyPI token.

@seisman
Copy link
Member Author

seisman commented Aug 19, 2020

We still need the https://github.com/fatiando/continuous-integration/blob/master/travis/deploy-gh-pages.sh script, because documentation of different versions are stored in separated directories.

We may not need the script, as the peaceiris/actions-gh-pages action supports "deploying to a subdirectory".

@weiji14 weiji14 added this to the v0.3.x milestone Sep 8, 2020
@seisman
Copy link
Member Author

seisman commented Nov 3, 2020

FYI, I've added a pypi token in secret pypi_password, which can be used in the https://github.com/marketplace/actions/pypi-publish action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants