You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The tests for surface currently use the raw data provided by pygmt.datasets.load_bathymetry_data and check the type and registration for the returned object. I think we should make two enhancements to these tests:
Supply pre-processed data to pygmt.surface, by either using blockmedian or adding pre-processed data to the cache. This is for a more realistic test to surface, since the raw bathymetric data should not be provided directly to surface, as demonstrated by the warnings:
surface [WARNING]: 77120 unusable points were supplied; these will be ignored.
surface [WARNING]: You should have pre-processed the data with block-mean, -median, or -mode.
surface [WARNING]: Check that previous processing steps write results with enough decimals.
surface [WARNING]: Possibly some data were half-way between nodes and subject to IEEE 754 rounding.
Use numpy.testing.assert_allclose to test values of the returned grid in addition to the type/registration.
Are you willing to help implement and maintain this feature? Yes
The text was updated successfully, but these errors were encountered:
Description of the desired feature
The tests for surface currently use the raw data provided by pygmt.datasets.load_bathymetry_data and check the type and registration for the returned object. I think we should make two enhancements to these tests:
Are you willing to help implement and maintain this feature? Yes
The text was updated successfully, but these errors were encountered: