Skip to content

Commit c308cb9

Browse files
committed
[mlir] Fix -Wsign-compare in ResolveShapedTypeResultDims.cpp (NFC)
/llvm-project/mlir/lib/Dialect/MemRef/Transforms/ResolveShapedTypeResultDims.cpp:98:19: error: comparison of integers of different signs: 'value_type' (aka 'long long') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare] if (*dimIndex >= reifiedResultShapes[resultNumber].size()) ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 parent 4f5d463 commit c308cb9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mlir/lib/Dialect/MemRef/Transforms/ResolveShapedTypeResultDims.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ struct DimOfReifyRankedShapedTypeOpInterface : public OpRewritePattern<OpTy> {
9595
return failure();
9696
unsigned resultNumber = dimValue.getResultNumber();
9797
// Do not apply pattern if the IR is invalid (dim out of bounds).
98-
if (*dimIndex >= reifiedResultShapes[resultNumber].size())
98+
if ((size_t)(*dimIndex) >= reifiedResultShapes[resultNumber].size())
9999
return rewriter.notifyMatchFailure(dimOp, "dimension is out of bounds");
100100
Value replacement = getValueOrCreateConstantIndexOp(
101101
rewriter, dimOp.getLoc(), reifiedResultShapes[resultNumber][*dimIndex]);

0 commit comments

Comments
 (0)