Unused local variable and fixed wrong type of the parameter #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorhu
approved these changes
Feb 5, 2024
Collaborator
connorhu
left a comment
connorhu
left a comment
There was a problem hiding this comment.
I prefer the two different modifications in separate commits, but the fix is fine! Thanks for the PR.
thePanz
requested changes
Feb 8, 2024
Member
thePanz
left a comment
thePanz
left a comment
There was a problem hiding this comment.
LGTM, please:
- Split the code change in two different commits
- Rebase on latest master branch
Then it can be merged
Author
|
You made me a quest from very very very dumb fix. |
Member
I feel like a clean way to proceed. Thanks for opening the PR! |
thePanz
approved these changes
Feb 9, 2024
Author
|
Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant problem of projects with Symfony1 - wrong type
stringin phpdoc block for function Collection::fromArray() must bearray