fiel change #1
Closed
fiel change #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flyingmana
pushed a commit
that referenced
this pull request
Nov 12, 2023
Flyingmana
pushed a commit
that referenced
this pull request
Jan 24, 2024
…nMage#3655) * Fixed strip_tags(): Passing null to parameter #1 in Fulltext.php * Preserve PHP7.4 return value.
Flyingmana
pushed a commit
that referenced
this pull request
Feb 14, 2024
…duct/Option/Type/File.php (OpenMage#3775)
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Fixed some phpstan issues * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector" This reverts commit 03e1514. * Revert ... * phpstan.dist.baseline.neon --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Show correct version * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Fixed phpcs compatibility warning * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6.
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Ignore mcrypt related warnings * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6.
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Removed MTF
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Security fix for TinyMCE - see GHSA-5359-pvf2-pw78 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6.
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Convert double-quotes to single-quotes
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Fixes some phpstan errors * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Update app/code/core/Mage/Tag/Model/Tag.php Co-authored-by: Ng Kiat Siong <[email protected]> * Updated docblock - have to keep array from parent method --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * DocBlock update * Update app/code/core/Mage/Adminhtml/Helper/Help/Mapping.php Co-authored-by: Ng Kiat Siong <[email protected]> * Update app/code/core/Mage/Core/Model/Session/Abstract.php Co-authored-by: Ng Kiat Siong <[email protected]> * Update app/code/core/Mage/Core/Model/Session/Abstract.php Co-authored-by: Ng Kiat Siong <[email protected]> --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
…ng` easier (OpenMage#4123) * Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Updates for 20.10.1 release * Re-add possibility to get original value * Changed default value * Moved method to Mage_Core_Block_Abstract * Ignore some phpcs-ecg errors [skip ci] * Added method to work with arrays * Added method to work with arrays (2) * Typo [skip ci] * Update app/code/core/Mage/Core/Model/Security/HtmlEscapedString.php Co-authored-by: Ng Kiat Siong <[email protected]> * Renamed methods * Reverted renaming, updated docblocks --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Patched PHPCS-ECG * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Updated baseline
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Updated test * Added test * Added test * Renamed and updated test * Updated test * Updated test * Updated test * Updated test * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Updated test (phpstan L9) * Updated test (fixed namespace) * Updated test (phpstan L9) * Added unit test to code style check and phpstan * Some cleanup * Some cleanup * Some cleanup * Updated workflow * ddev shortcut [ski ci] * Moved phphunit config file * Merged phpunit & sonar workflow * PhpUnit fix - PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /home/runner/work/magento-lts/magento-lts/lib/Varien/Object.php on line 594 * Fix linefeed (?) * Fix config * Fixed invalid php version * Use minimum version * Use minimum version for SonarScan * Fix command [ski ci] * Enable xdebug * Added test, ref OpenMage#4123 * Revert "Some cleanup" This reverts commit 6d45ed6. * Revert "PhpUnit fix" This reverts commit f4935f1. * Updated test * Updated docblocks * Revert "Fix linefeed (?)" This reverts commit dee0422. * Added tests * Added tests * Added tests [skip ci] * Reverted changes to Mage_Core_Model_Website * Updated config * Updated .gitignore * Updated workflow * Updated workflow typo * Updated workflow continue on error * Updated workflow if condition * Updated workflow [skip ci] * Moved tests to root (as common) * Fixed paths * Fixed paths * Fixed paths * CS fix * Added test * Added test * Added groups/suites * Updated test * CS fix * Updated .gitignore * Updated phpunit.xml.dist * Added test * Added tests * Added tests * Added tests * Added tests * CS fix * CS fix * Added tests * Added tests * Added tests * Added tests * CS/PhpStan fixes * Update - some tests commented - need files changes * Nicer output? * Don't wait for phpcs * Revert output * Updated workflows * Added test * Added phpunit command to composer.json * Updated DDEV commands * Updated composer scripts --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Updated test * Added test * Added test * Renamed and updated test * Updated test * Updated test * Updated test * Updated test * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Updated test (phpstan L9) * Updated test (fixed namespace) * Updated test (phpstan L9) * Added unit test to code style check and phpstan * Some cleanup * Some cleanup * Some cleanup * Updated workflow * ddev shortcut [ski ci] * Moved phphunit config file * Merged phpunit & sonar workflow * PhpUnit fix - PHP Deprecated: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in /home/runner/work/magento-lts/magento-lts/lib/Varien/Object.php on line 594 * Fix linefeed (?) * Fix config * Fixed invalid php version * Use minimum version * Use minimum version for SonarScan * Fix command [ski ci] * Enable xdebug * Added test, ref OpenMage#4123 * Revert "Some cleanup" This reverts commit 6d45ed6. * Revert "PhpUnit fix" This reverts commit f4935f1. * Updated test * Updated docblocks * Revert "Fix linefeed (?)" This reverts commit dee0422. * Added tests * Added tests * Added tests [skip ci] * Reverted changes to Mage_Core_Model_Website * Updated config * Updated .gitignore * Updated workflow * Updated workflow typo * Updated workflow continue on error * Updated workflow if condition * Updated workflow [skip ci] * Moved tests to root (as common) * Fixed paths * Fixed paths * Fixed paths * CS fix * Added test * Added test * Added groups/suites * Updated test * CS fix * Updated .gitignore * Updated phpunit.xml.dist * Added test * Added tests * Added tests * Added tests * Added tests * CS fix * CS fix * Added tests * Added tests * Added tests * Added tests * CS/PhpStan fixes * Update - some tests commented - need files changes * Nicer output? * Don't wait for phpcs * Revert output * Updated workflows * Added test * Added phpunit command to composer.json * Updated DDEV commands * Fixed phpunit commands at composer.json * WIP * phpcs and phpstan fixes * Updated tests * Moved test to correct directory * Added tests --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * DDEV localdev [skip ci] * Typo [skip ci] * Fix * Changed path --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
OpenMage#4212) * Fixed strcmp(): Passing null to parameter #1 ($string1) of type string is deprecated * Update app/code/core/Mage/Customer/controllers/AccountController.php Co-authored-by: Sven Reichel <[email protected]> * Update app/code/core/Mage/Customer/controllers/AccountController.php Fixed typo --------- Co-authored-by: Sven Reichel <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* PHP8: base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated - OpenMage#4243 (comment) * refactor * refactor * refactor * refactor [skip ci] * Update app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php Co-authored-by: Ng Kiat Siong <[email protected]> --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
…meter #1 ($datetime) (OpenMage#4339)
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Updated documentation * Updated documentation * Updated documentation * Updated documentation * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * WIP - Updated documentation * Added OpenMage#4208 * Added OpenMage#3150 (reply in thread) * little update - modules - new config/events _ ... * Updated modules * typo * typo * added .htaccess
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Install TinyMCE via composer * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Install TinyMCE via composer * Back to v6.8 * Updated phpstan.dist.baseline.neon for updated composer.lock * Fixed merge conflict * Updated TinyMCE to v7.3 * Typo * Updated composer.lock * Updated to 7.4 * Added license-key, updated to 7.4.1 * Updated .phpstan.dist.baseline.neon * Moved block files from adminhtml/cms to cms/adminhtml * Removed unused test * Updated phpstorm meta files * typos + phpstan baseline * Pinned plugin commit until there is no release * Use plugin 1.1 release * rector * Merge branch 'main' into tinymce # Conflicts: # composer.lock * Fixed merge error * Revert "Moved block files from adminhtml/cms to cms/adminhtml" This reverts commit 3641080 * removed previously added files * removed previously added classes from meta files * Fixed composer * Updated composer * Updated composer * Updated composer * composer plugin * Updated plugin for tests [skip ci] * Updated plugin * updated composer plug-in --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Flyingmana
pushed a commit
that referenced
this pull request
May 8, 2025
* Rector: CQ - UnusedForeachValueToArrayKeysRector (#1) * Rector: CQ - UnusedForeachValueToArrayKeysRector See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector * fixes + phpstan See fix at rector: rectorphp/rector-src#6164 * Revert "Rector: CQ - UnusedForeachValueToArrayKeysRector (#1)" This reverts commit 3d7eaf6. * Drop php7 support - updated workflows - phpstan baseline (will be fixed later) * Updated README.md (draft) * Update composer.json Co-authored-by: Ng Kiat Siong <[email protected]> * Update * update baseline * composer update * fix rector (unit tests) * fix rector (incomplete unit tests) * fix phpunit tests (null is not a valid value) * phpstan (unit tests) * fix php8 deprecation - https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation * phpunit (comment test - doesNotPerformAssertions) * phpcs-fixer * removed libxml_disable_entity_loader calls - https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation - On code that only runs on PHP 8.0 and later, it is now safe to remove all function calls * replace strftime with date - https://php.watch/versions/8.1/strftime-gmstrftime-deprecated#replacements * rector: RemoveParentCallWithoutParentRector * rector config * phpstan --------- Co-authored-by: Ng Kiat Siong <[email protected]> Co-authored-by: Colin Mollenhour <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a test for PR actions