Fixed strtr(): Passing null to parameter #1 ($string) of type string is deprecated (OpenMage#3639)

kiatng · web-flow · commit 0ac3f19a23ee · 2023-11-10T14:09:50.000Z
diff --git a/app/code/core/Mage/Catalog/Helper/Product/Url.php b/app/code/core/Mage/Catalog/Helper/Product/Url.php
@@ -115,6 +115,6 @@ public function getConvertTable()
      */
     public function format($string)
     {
-        return strtr($string, $this->getConvertTable());
+        return $string === null ? '' : strtr($string, $this->getConvertTable());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,6 @@ public function getConvertTable()`
`115`	`115`	`*/`
`116`	`116`	`public function format($string)`
`117`	`117`	`{`
`118`		`- return strtr($string, $this->getConvertTable());`
	`118`	`+ return $string === null ? '' : strtr($string, $this->getConvertTable());`
`119`	`119`	`}`
`120`	`120`	`}`