First impl #1
Merged
First impl #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
May 16, 2020
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
The algorithm seems ok, I would add some docs and then we should be good to go.
(there will be bugs, but it should unblock us to ship Fastify v3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcollina would you mind to give it a check if you spot potential issues in code?
I implemented this logic: https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.appendix.B.1
It replaces all
$refwith a new path to local/definitionsadded by codeIt supports draft-07 (supported by ajv) with a small tweak to add draft-08 in future.
I tried it roughly with
fastify-swaggerand it does the jobTODO