Skip to content

Conversation

@ShahanaFarooqui
Copy link
Collaborator

This reverts commit, as an alternative fix has already been introduced in PR #8547 to restore reproducible builds.

This reversion is necessary otherwise Docker image building will fail with GitHub Actions or via build-release.sh. The issue arises from Cargo’s inability to resolve the git URL dependencies for clnrest’s utoipa and utoipa-swagger-ui packages within these build contexts. While direct docker buildx commands succeeds, Github Action or build-release.sh modifies the build context in a way that prevents Cargo from locating the specific git commit for these dependencies.

References:
Discussion
Failed Action
PR with the fix

Changelog-None.

This reverts [commit](ElementsProject@cd1ec72), as an alternative fix has already been introduced in PR [ElementsProject#8547](ElementsProject#8547) to restore reproducible builds.

This reversion is necessary because otherwise Docker image building will fail with GitHub Actions or via build-release.sh. The issue arises from Cargo’s inability to resolve the git URL dependencies for clnrest’s utoipa and utoipa-swagger-ui packages within these build contexts. While direct `docker buildx` commands succeeds, Github Action or build-release.sh modifies the build context in a way that prevents Cargo from locating the specific git commit for these dependencies.

References:
ElementsProject#8530 (comment)
https://github.com/ElementsProject/lightning/actions/runs/17435823432
Added fixed SOURCE_DATE_EPOCH flag for reproducible ubuntu builds [8547](ElementsProject#8547)

Changelog-None.
@ShahanaFarooqui ShahanaFarooqui added this to the v25.12 milestone Nov 6, 2025
@daywalker90
Copy link
Collaborator

The Rust crate Release Action also refuses to publish any crate while clnrest has git dependencies, a bit silly...

@madelinevibes madelinevibes added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Nov 12, 2025
@sangbida sangbida merged commit 76592ea into ElementsProject:master Nov 12, 2025
72 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants