Skip to content

Remove code that sends htlc commit sigs to lightningd which then get thrown away #6386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddustin opened this issue Jul 6, 2023 · 0 comments

Comments

@ddustin
Copy link
Collaborator

ddustin commented Jul 6, 2023

Long ago code was written to send our htlc sigs to lightningd to store or do something with. Lightningd currently does nothing with them.

Removing this code would be a win

Rusty's comment:
Hmm, I chased this down and it seems that we send lightningd the commit sigs for our commit tx and it never uses them. A separate patch to remove that would be a win! (I was confused looking at this, thinking it surely needed the htlc sigs for the other inflights, but no...)

Originally posted by @rustyrussell in #6253 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant