Merge branch 'master' of https://github.com/ElectronNET/Electron.NET

Author: GregorBiswanger

ElectronNET.API/Shell.cs

@@ -59,22 +59,22 @@ public Task<bool> ShowItemInFolderAsync(string fullPath)
         }
 
         /// <summary>
-        /// Open the given file in the desktop’s default manner.
+        /// Open the given file in the desktop's default manner.
         /// </summary>
-        /// <param name="fullPath"></param>
-        /// <returns>Whether the item was successfully opened.</returns>
-        public Task<bool> OpenPathAsync(string fullPath)
+        /// <param name="path">The path to the file.</param>
+        /// <returns>The error message corresponding to the failure if a failure occurred, otherwise <see cref="string.Empty"/>.</returns>
+        public Task<string> OpenPathAsync(string path)
         {
-            var taskCompletionSource = new TaskCompletionSource<bool>();
+            var taskCompletionSource = new TaskCompletionSource<string>();
 
             BridgeConnector.Socket.On("shell-openPathCompleted", (success) =>
             {
                 BridgeConnector.Socket.Off("shell-openPathCompleted");
 
-                taskCompletionSource.SetResult((bool)success);
+                taskCompletionSource.SetResult((string) success);
             });
 
-            BridgeConnector.Socket.Emit("shell-openPath", fullPath);
+            BridgeConnector.Socket.Emit("shell-openPath", path);
 
             return taskCompletionSource.Task;
         }

ElectronNET.Host/api/shell.js

@@ -9,11 +9,11 @@ export = (socket: SocketIO.Socket) => {
         electronSocket.emit('shell-showItemInFolderCompleted', success);
     });
 
-    socket.on('shell-openPath', async (fullPath) => {
-        const success = await shell.openPath(fullPath);
+    socket.on('shell-openPath', async (path) => {
+        const errorMessage = await shell.openPath(path);
 
-        electronSocket.emit('shell-openPathCompleted', success);
-    });
+        electronSocket.emit('shell-openPathCompleted', errorMessage);
+    })
 
     socket.on('shell-openExternal', (url, options) => {
         let success = true;