changed App.GetNameAsync and App.SetNameAsync to App.Name - Fixed the Splashscreen bug #357 #350

Author: GregorBiswanger

Changelog.md

@@ -2,6 +2,10 @@
 
 # 8.31.1
 
+ElectronNET.API:
+
+* New Feature: Electron 8.2.3 support, but not all new features (we search contributors)
+
 # Released
 
 # 7.30.2

ElectronNET.API/App.cs

@@ -351,6 +351,40 @@ public event Action<bool> AccessibilitySupportChanged
 
         private event Action<bool> _accessibilitySupportChanged;
 
+        /// <summary>
+        /// A property that indicates the current application's name, which is the
+        /// name in the application's `package.json` file.
+        ///
+        /// Usually the `name` field of `package.json` is a short lowercase name, according
+        /// to the npm modules spec.You should usually also specify a `productName` field,
+        /// which is your application's full capitalized name, and which will be preferred
+        /// over `name` by Electron.
+        /// </summary>
+        public string Name
+        {
+            get
+            {
+                return Task.Run<string>(() =>
+                {
+                    var taskCompletionSource = new TaskCompletionSource<string>();
+
+                    BridgeConnector.Socket.On("appGetNameCompleted", (result) =>
+                    {
+                        BridgeConnector.Socket.Off("appGetNameCompleted");
+                        taskCompletionSource.SetResult((string)result);
+                    });
+
+                    BridgeConnector.Socket.Emit("appGetName");
+
+                    return taskCompletionSource.Task;
+                }).Result;
+            }
+            set
+            {
+                BridgeConnector.Socket.Emit("appSetName", value);
+            }
+        }
+
         internal App() 
         {
             CommandLine = new CommandLine();
@@ -551,42 +585,6 @@ public void SetPath(string name, string path)
             }
         }
 
-        /// <summary>
-        /// Usually the name field of package.json is a short lowercased name, according to
-        /// the npm modules spec. You should usually also specify a productName field, which
-        /// is your application's full capitalized name, and which will be preferred over
-        /// name by Electron.
-        /// </summary>
-        /// <returns>The current application’s name, which is the name in the application’s package.json file.</returns>
-        public async Task<string> GetNameAsync(CancellationToken cancellationToken = default(CancellationToken))
-        {
-            cancellationToken.ThrowIfCancellationRequested();
-
-            var taskCompletionSource = new TaskCompletionSource<string>();
-            using(cancellationToken.Register(() => taskCompletionSource.TrySetCanceled()))
-            {
-                BridgeConnector.Socket.On("appGetNameCompleted", (name) =>
-                {
-                    BridgeConnector.Socket.Off("appGetNameCompleted");
-                    taskCompletionSource.SetResult(name.ToString());
-                });
-
-                BridgeConnector.Socket.Emit("appGetName");
-
-                return await taskCompletionSource.Task
-                    .ConfigureAwait(false);
-            }
-        }
-
-        /// <summary>
-        /// Overrides the current application's name.
-        /// </summary>
-        /// <param name="name">Application's name</param>
-        public void SetName(string name)
-        {
-            BridgeConnector.Socket.Emit("appSetName", name);
-        }
-
         /// <summary>
         /// The current application locale.
         ///  Note: When distributing your packaged app, you have to also ship the locales

ElectronNET.Host/api/app.js

@@ -137,12 +137,11 @@ export = (socket: SocketIO.Socket, app: Electron.App) => {
     });
 
     socket.on('appGetName', () => {
-        const name = app.getName();
-        electronSocket.emit('appGetNameCompleted', name);
+        electronSocket.emit('appGetNameCompleted', app.name);
     });
 
     socket.on('appSetName', (name) => {
-        app.setName(name);
+        app.name = name;
     });
 
     socket.on('appGetLocale', () => {