refactor: shim for _PyArg_CheckPositional

Author: Xmader

include/pyshim.hh

@@ -43,8 +43,7 @@ typedef struct {
  *        Since Python 3.13, `_PyArg_CheckPositional` function became an internal API.
  * @see Modified from https://github.com/python/cpython/blob/v3.13.0rc1/Python/getargs.c#L2738-L2780
  */
-#if PY_VERSION_HEX >= 0x030d0000 // Python version is greater than 3.13
-inline int _PyArg_CheckPositional(const char *name, Py_ssize_t nargs, Py_ssize_t min, Py_ssize_t max) {
+inline int PyArg_CheckNArgs(const char *name, Py_ssize_t nargs, Py_ssize_t min, Py_ssize_t max) {
   if (nargs < min) {
     PyErr_Format(
       PyExc_TypeError,
@@ -67,7 +66,6 @@ inline int _PyArg_CheckPositional(const char *name, Py_ssize_t nargs, Py_ssize_t
 
   return 1;
 }
-#endif
 
 /**
  * @brief Shim for `_PyDictView_New`.

src/JSArrayProxy.cc

@@ -790,7 +790,7 @@ PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_insert(JSArrayProxy *self,
   Py_ssize_t index;
   PyObject *value;
 
-  if (!_PyArg_CheckPositional("insert", nargs, 2, 2)) {
+  if (!PyArg_CheckNArgs("insert", nargs, 2, 2)) {
     return NULL;
   }
 
@@ -900,7 +900,7 @@ PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_extend(JSArrayProxy *self,
 PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_pop(JSArrayProxy *self, PyObject *const *args, Py_ssize_t nargs) {
   Py_ssize_t index = -1;
 
-  if (!_PyArg_CheckPositional("pop", nargs, 0, 1)) {
+  if (!PyArg_CheckNArgs("pop", nargs, 0, 1)) {
     return NULL;
   }
 
@@ -988,7 +988,7 @@ PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_index(JSArrayProxy *self,
   Py_ssize_t start = 0;
   Py_ssize_t stop = PY_SSIZE_T_MAX;
 
-  if (!_PyArg_CheckPositional("index", nargs, 1, 3)) {
+  if (!PyArg_CheckNArgs("index", nargs, 1, 3)) {
     return NULL;
   }
   value = args[0];

src/JSObjectProxy.cc

@@ -623,7 +623,7 @@ PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_get_method(JSObjectProxy
   PyObject *key;
   PyObject *default_value = Py_None;
 
-  if (!_PyArg_CheckPositional("get", nargs, 1, 2)) {
+  if (!PyArg_CheckNArgs("get", nargs, 1, 2)) {
     return NULL;
   }
   key = args[0];
@@ -647,7 +647,7 @@ PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_setdefault_method(JSObje
   PyObject *key;
   PyObject *default_value = Py_None;
 
-  if (!_PyArg_CheckPositional("setdefault", nargs, 1, 2)) {
+  if (!PyArg_CheckNArgs("setdefault", nargs, 1, 2)) {
     return NULL;
   }
   key = args[0];
@@ -679,7 +679,7 @@ PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_pop_method(JSObjectProxy
   PyObject *key;
   PyObject *default_value = NULL;
 
-  if (!_PyArg_CheckPositional("pop", nargs, 1, 2)) {
+  if (!PyArg_CheckNArgs("pop", nargs, 1, 2)) {
     return NULL;
   }
   key = args[0];