Optimize IDisposable implementations #344
Conversation
* Optimize IDisposable implementations * optimize new List<>(1) * Optimize EnableSystemOperationRegistration() * Fix Race condition in tests * Fix Race condition in tests * Add [MethodImpl(MethodImplOptions.NoInlining)]
| @@ -11,17 +11,26 @@ namespace Xtensive.Orm | |||
| { | |||
| public partial class Session | |||
| { | |||
| public readonly struct SystemLogicOnlyRegionScope : IDisposable | |||
There was a problem hiding this comment.
I believe that we can make it internal and roll back to IDisposable in the DirectSessionAccessor.
Do you have any usage of DirectSessionAccessor.OpenSystemLogicOnlyRegion method?
There was a problem hiding this comment.
Do you have any usage of
DirectSessionAccessor.OpenSystemLogicOnlyRegionmethod?
Yes, we do
There was a problem hiding this comment.
It is reasonable to restrict access to the scope constructor to keep creations within project
There was a problem hiding this comment.
roll back to
IDisposablein theDirectSessionAccessor.
returning IDisposable requires heap allocation. That was the reason of this PR to avoid unnecessary allocations.
There was a problem hiding this comment.
I know, this is why I no longer require you to make type internal. I'm talking about the type constructor, there is no reason for it to be used outside project.
There was a problem hiding this comment.
Changed SystemLogicOnlyRegionScope() ctor to be internal
OpenSystemLogicOnlyRegion(),EnableSystemOperationRegistration(),DisableSystemOperationRegistration()alloc-less (there were 2 allocations: forDisposable<>& closure)RegisterRoot()EmptyDisposablewhere possibleif (!hashSet.Contains(x)) hashSet.Add(x);pattern intohashSet.Add(x)to avoid double searchPrefetchManagerBasicTest: prohibit JIT to inline the function