Sql Server v13+ Datetime subtraction issue fix #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a test for the overflow case? Could you please add one if it doesn't exist? |
|
There is a test called |
AlexUstinov
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous movement to
DATEDIFF_BIG(#198) appeared to have problems with someDateTimevalues.This PR tries to keep better performance of less calculations while not sacrificing full range of dates to be supported. It brings back previous formula of date diff calculation for some scenarios (
DATEDIFF_BIGcan't handle diff in nanoseconds fully, more info here), while using relatively lightweight date diff calculation for the most part.