chore: add version checking to django channels #15484
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 3 ms. The average import time from base is: 249 ± 4 ms. The import time difference between this PR and base is: -2.3 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate add-version-checking-django-channels (ced1023) with baseline main (34ab1fa) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.209µs (SLO: <10.000µs 📉 -47.9%) vs baseline: 📈 +26.7% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.086µs (SLO: <10.000µs 📉 -89.1%) vs baseline: ~same Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathjoin_aspectTime: ✅ 6.115µs (SLO: <10.000µs 📉 -38.8%) vs baseline: -0.4% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 2.298µs (SLO: <10.000µs 📉 -77.0%) vs baseline: ~same Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.422µs (SLO: <10.000µs 📉 -65.8%) vs baseline: -0.4% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.6% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.736µs (SLO: <10.000µs 📉 -52.6%) vs baseline: -0.2% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.580µs (SLO: <10.000µs 📉 -84.2%) vs baseline: +0.3% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.682µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +0.5% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.4% ✅ ospathsplitdrive_noaspectTime: ✅ 0.700µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.5% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.4% ✅ ospathsplitext_aspectTime: ✅ 4.500µs (SLO: <10.000µs 📉 -55.0%) vs baseline: -0.3% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 1.381µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.4% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.380µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +14.9% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +5.4% ✅ 1-count-metrics-100-timesTime: ✅ 200.405µs (SLO: <220.000µs -8.9%) vs baseline: -1.4% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.4% ✅ 1-distribution-metric-1-timesTime: ✅ 3.298µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +0.1% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.800µs (SLO: <230.000µs -6.2%) vs baseline: -0.4% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.160µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.4% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.4% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.904µs (SLO: <150.000µs -9.4%) vs baseline: +0.2% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +5.4% ✅ 1-rate-metric-1-timesTime: ✅ 3.074µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -0.3% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 215.054µs (SLO: <250.000µs 📉 -14.0%) vs baseline: +0.4% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +5.6% ✅ 100-count-metrics-100-timesTime: ✅ 20.180ms (SLO: <22.000ms -8.3%) vs baseline: -0.9% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.306ms (SLO: <2.300ms +0.3%) vs baseline: +0.4% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.2% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.402ms (SLO: <1.550ms -9.5%) vs baseline: -0.2% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.229ms (SLO: <2.550ms 📉 -12.6%) vs baseline: -0.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.3% ✅ flush-1-metricTime: ✅ 4.629µs (SLO: <20.000µs 📉 -76.9%) vs baseline: -1.3% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ flush-100-metricsTime: ✅ 174.143µs (SLO: <250.000µs 📉 -30.3%) vs baseline: -0.3% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.173ms (SLO: <2.500ms 📉 -13.1%) vs baseline: -0.6% Memory: ✅ 35.960MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.7% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
quinna-h
added
the
changelog/no-changelog
dubloom
left a comment
dubloom
left a comment
There was a problem hiding this comment.
We could do parse_version(getattr(channels, "version", "")) but that's a nit and may be less readable
LGTM !
## Description <!-- Provide an overview of the change and motivation for the change --> Quick fix for version checking for django channels, to fix `AttributeError` when `__version__` not found ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 00fdce8)
## Description <!-- Provide an overview of the change and motivation for the change --> Quick fix for version checking for django channels, to fix `AttributeError` when `__version__` not found ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit 00fdce8)
Backport 00fdce8 from #15484 to 4.0. ## Description <!-- Provide an overview of the change and motivation for the change --> Quick fix for version checking for django channels, to fix `AttributeError` when `__version__` not found ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> Co-authored-by: Quinna Halim <[email protected]>
Description
Quick fix for version checking for django channels, to fix
AttributeErrorwhen__version__not foundTesting
Risks
Additional Notes