Skip to content

Commit e079846

Browse files
committed
fix typing
1 parent c387059 commit e079846

File tree

16 files changed

+39
-34
lines changed

16 files changed

+39
-34
lines changed

ddtrace/_trace/_span_link.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
Usage
1414
-----
1515
16-
SpanLinks can be set using :meth:`ddtrace.Span.link_span(...)` Ex::
16+
SpanLinks can be set using :meth:`ddtrace._trace.span.Span.link_span(...)` Ex::
1717
1818
from ddtrace.trace import tracer
1919

ddtrace/appsec/_capabilities.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def _asm_feature_is_required() -> bool:
5959
return (_FEATURE_REQUIRED & flags) != 0
6060

6161

62-
def _rc_capabilities(test_tracer: Optional[ddtrace.Tracer] = None) -> Flags:
62+
def _rc_capabilities(test_tracer: Optional[ddtrace._trace.tracer.Tracer] = None) -> Flags:
6363
tracer = ddtrace.tracer if test_tracer is None else test_tracer
6464
value = Flags(0)
6565
if ddtrace.config._remote_config_enabled:
@@ -74,7 +74,7 @@ def _rc_capabilities(test_tracer: Optional[ddtrace.Tracer] = None) -> Flags:
7474
return value
7575

7676

77-
def _appsec_rc_capabilities(test_tracer: Optional[ddtrace.Tracer] = None) -> str:
77+
def _appsec_rc_capabilities(test_tracer: Optional[ddtrace._trace.tracer.Tracer] = None) -> str:
7878
r"""return the bit representation of the composed capabilities in base64
7979
bit 0: Reserved
8080
bit 1: ASM 1-click Activation

ddtrace/contrib/internal/logging/patch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def _w_makeRecord(func, instance, args, kwargs):
8080
# logs from internal logger may explicitly pass the current span to
8181
# avoid deadlocks in getting the current span while already in locked code.
8282
span_from_log = getattr(record, _LOG_SPAN_KEY, None)
83-
if isinstance(span_from_log, ddtrace.Span):
83+
if isinstance(span_from_log, ddtrace._trace.span.Span):
8484
span = span_from_log
8585

8686
if tracer:

ddtrace/contrib/internal/sqlalchemy/engine.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def trace_engine(engine, tracer=None, service=None):
3737
Add tracing instrumentation to the given sqlalchemy engine or instance.
3838
3939
:param sqlalchemy.Engine engine: a SQLAlchemy engine class or instance
40-
:param ddtrace.Tracer tracer: a tracer instance. will default to the global
40+
:param ddtrace._trace.tracer.Tracer tracer: a tracer instance. will default to the global
4141
:param str service: the name of the service to trace.
4242
"""
4343
tracer = tracer or ddtrace.tracer # by default use global

ddtrace/contrib/internal/trace_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ def _store_request_headers(headers, span, integration_config):
257257
:param headers: All the request's http headers, will be filtered through the whitelist
258258
:type headers: dict or list
259259
:param span: The Span instance where tags will be stored
260-
:type span: ddtrace.Span
260+
:type span: ddtrace._trace.span.Span
261261
:param integration_config: An integration specific config object.
262262
:type integration_config: ddtrace.settings.IntegrationConfig
263263
"""
@@ -271,7 +271,7 @@ def _store_response_headers(headers, span, integration_config):
271271
:param headers: All the response's http headers, will be filtered through the whitelist
272272
:type headers: dict or list
273273
:param span: The Span instance where tags will be stored
274-
:type span: ddtrace.Span
274+
:type span: ddtrace._trace.span.Span
275275
:param integration_config: An integration specific config object.
276276
:type integration_config: ddtrace.settings.IntegrationConfig
277277
"""

ddtrace/contrib/internal/unittest/patch.py

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,9 @@ def _is_marked_as_unskippable(test_object) -> bool:
129129
)
130130

131131

132-
def _update_skipped_elements_and_set_tags(test_module_span: ddtrace.Span, test_session_span: ddtrace.Span):
132+
def _update_skipped_elements_and_set_tags(
133+
test_module_span: ddtrace._trace.span.Span, test_session_span: ddtrace._trace.span.Span
134+
):
133135
global _global_skipped_elements
134136
_global_skipped_elements += 1
135137

@@ -141,7 +143,7 @@ def _update_skipped_elements_and_set_tags(test_module_span: ddtrace.Span, test_s
141143
test_session_span.set_tag_str(test.ITR_DD_CI_ITR_TESTS_SKIPPED, "true")
142144

143145

144-
def _store_test_span(item, span: ddtrace.Span):
146+
def _store_test_span(item, span: ddtrace._trace.span.Span):
145147
"""Store datadog span at `unittest` test instance."""
146148
item._datadog_span = span
147149

@@ -172,7 +174,7 @@ def _is_test(item) -> bool:
172174
return True
173175

174176

175-
def _extract_span(item) -> Union[ddtrace.Span, None]:
177+
def _extract_span(item) -> Union[ddtrace._trace.span.Span, None]:
176178
return getattr(item, "_datadog_span", None)
177179

178180

@@ -187,23 +189,23 @@ def _extract_test_method_name(test_object) -> str:
187189
return getattr(test_object, "_testMethodName", "")
188190

189191

190-
def _extract_session_span() -> Union[ddtrace.Span, None]:
192+
def _extract_session_span() -> Union[ddtrace._trace.span.Span, None]:
191193
return getattr(_CIVisibility, "_datadog_session_span", None)
192194

193195

194-
def _extract_module_span(module_identifier: str) -> Union[ddtrace.Span, None]:
196+
def _extract_module_span(module_identifier: str) -> Union[ddtrace._trace.span.Span, None]:
195197
if hasattr(_CIVisibility, "_unittest_data") and module_identifier in _CIVisibility._unittest_data["modules"]:
196198
return _CIVisibility._unittest_data["modules"][module_identifier].get("module_span")
197199
return None
198200

199201

200-
def _extract_suite_span(suite_identifier: str) -> Union[ddtrace.Span, None]:
202+
def _extract_suite_span(suite_identifier: str) -> Union[ddtrace._trace.span.Span, None]:
201203
if hasattr(_CIVisibility, "_unittest_data") and suite_identifier in _CIVisibility._unittest_data["suites"]:
202204
return _CIVisibility._unittest_data["suites"][suite_identifier].get("suite_span")
203205
return None
204206

205207

206-
def _update_status_item(item: ddtrace.Span, status: str):
208+
def _update_status_item(item: ddtrace._trace.span.Span, status: str):
207209
"""
208210
Sets the status for each Span implementing the test FAIL logic override.
209211
"""
@@ -266,7 +268,7 @@ def _generate_session_resource(test_command: str) -> str:
266268
return "{}".format(test_command)
267269

268270

269-
def _set_test_skipping_tags_to_span(span: ddtrace.Span):
271+
def _set_test_skipping_tags_to_span(span: ddtrace._trace.span.Span):
270272
span.set_tag_str(test.ITR_TEST_SKIPPING_ENABLED, "true")
271273
span.set_tag_str(test.ITR_TEST_SKIPPING_TYPE, TEST)
272274
span.set_tag_str(test.ITR_TEST_SKIPPING_TESTS_SKIPPED, "false")
@@ -368,7 +370,10 @@ def _finish_remaining_suites_and_modules(seen_suites: dict, seen_modules: dict):
368370

369371

370372
def _update_remaining_suites_and_modules(
371-
test_module_suite_path: str, test_module_path: str, test_module_span: ddtrace.Span, test_suite_span: ddtrace.Span
373+
test_module_suite_path: str,
374+
test_module_path: str,
375+
test_module_span: ddtrace._trace.span.Span,
376+
test_suite_span: ddtrace._trace.span.Span,
372377
):
373378
"""
374379
Updates the remaining test suite and test counter and finishes spans when these have finished their execution.
@@ -384,7 +389,7 @@ def _update_remaining_suites_and_modules(
384389
_finish_span(test_module_span)
385390

386391

387-
def _update_test_skipping_count_span(span: ddtrace.Span):
392+
def _update_test_skipping_count_span(span: ddtrace._trace.span.Span):
388393
if _CIVisibility.test_skipping_enabled():
389394
span.set_metric(test.ITR_TEST_SKIPPING_COUNT, _global_skipped_elements)
390395

@@ -622,7 +627,7 @@ def collect_text_test_runner_session(func, instance: unittest.TestSuite, args: t
622627
return result
623628

624629

625-
def _start_test_session_span(instance) -> ddtrace.Span:
630+
def _start_test_session_span(instance) -> ddtrace._trace.span.Span:
626631
"""
627632
Starts a test session span and sets the required tags for a `unittest` session instance.
628633
"""
@@ -663,7 +668,7 @@ def _start_test_session_span(instance) -> ddtrace.Span:
663668
return test_session_span
664669

665670

666-
def _start_test_module_span(instance) -> ddtrace.Span:
671+
def _start_test_module_span(instance) -> ddtrace._trace.span.Span:
667672
"""
668673
Starts a test module span and sets the required tags for a `unittest` module instance.
669674
"""
@@ -706,7 +711,7 @@ def _start_test_module_span(instance) -> ddtrace.Span:
706711
return test_module_span
707712

708713

709-
def _start_test_suite_span(instance) -> ddtrace.Span:
714+
def _start_test_suite_span(instance) -> ddtrace._trace.span.Span:
710715
"""
711716
Starts a test suite span and sets the required tags for a `unittest` suite instance.
712717
"""
@@ -742,7 +747,7 @@ def _start_test_suite_span(instance) -> ddtrace.Span:
742747
return test_suite_span
743748

744749

745-
def _start_test_span(instance, test_suite_span: ddtrace.Span) -> ddtrace.Span:
750+
def _start_test_span(instance, test_suite_span: ddtrace._trace.span.Span) -> ddtrace._trace.span.Span:
746751
"""
747752
Starts a test span and sets the required tags for a `unittest` test instance.
748753
"""
@@ -787,7 +792,7 @@ def _start_test_span(instance, test_suite_span: ddtrace.Span) -> ddtrace.Span:
787792
return span
788793

789794

790-
def _finish_span(current_span: ddtrace.Span):
795+
def _finish_span(current_span: ddtrace._trace.span.Span):
791796
"""
792797
Finishes active span and populates span status upwards
793798
"""

ddtrace/internal/ci_visibility/api/_base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ class TestVisibilitySessionSettings:
7676

7777
def __post_init__(self):
7878
if not isinstance(self.tracer, Tracer):
79-
raise TypeError("tracer must be a ddtrace.Tracer")
79+
raise TypeError("tracer must be a ddtrace._trace.tracer.Tracer")
8080
if not isinstance(self.workspace_path, Path):
8181
raise TypeError("root_dir must be a pathlib.Path")
8282
if not self.workspace_path.is_absolute():

ddtrace/internal/ci_visibility/coverage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def _switch_coverage_context(
131131

132132

133133
def _report_coverage_to_span(
134-
coverage_data: Coverage, span: ddtrace.Span, root_dir: str, framework: Optional[TEST_FRAMEWORKS] = None
134+
coverage_data: Coverage, span: ddtrace._trace.span.Span, root_dir: str, framework: Optional[TEST_FRAMEWORKS] = None
135135
):
136136
# Experimental feature to use internal coverage collection
137137
if USE_DD_COVERAGE:

ddtrace/internal/ci_visibility/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def get_source_lines_for_test_method(
5050

5151

5252
def _add_start_end_source_file_path_data_to_span(
53-
span: ddtrace.Span, test_method_object, test_name: str, repo_directory: str
53+
span: ddtrace._trace.span.Span, test_method_object, test_name: str, repo_directory: str
5454
):
5555
if not test_method_object:
5656
log.debug(
@@ -75,7 +75,7 @@ def _add_start_end_source_file_path_data_to_span(
7575
span.set_tag(test.SOURCE_END, end_line)
7676

7777

78-
def _add_pct_covered_to_span(coverage_data: dict, span: ddtrace.Span):
78+
def _add_pct_covered_to_span(coverage_data: dict, span: ddtrace._trace.span.Span):
7979
if not coverage_data or PCT_COVERED_KEY not in coverage_data:
8080
log.warning("Tried to add total covered percentage to session span but no data was found")
8181
return

ddtrace/internal/opentelemetry/trace.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ def start_span(
103103
curr_otel_span = get_current_span(context)
104104
if curr_otel_span is INVALID_SPAN:
105105
# There is no active datadog/otel span
106-
dd_active = None # type: Optional[Union[ddtrace.trace.Context, ddtrace.Span]]
106+
dd_active = None # type: Optional[Union[ddtrace.trace.Context, ddtrace._trace.span.Span]]
107107
elif isinstance(curr_otel_span, Span):
108108
# Get underlying ddtrace span from the active otel span
109109
dd_active = curr_otel_span._ddspan

ddtrace/internal/runtime/runtime_metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def __init__(self, interval=_get_interval_or_default(), tracer=ddtrace.tracer, d
7878
self._dogstatsd_client: DogStatsd = get_dogstatsd_client(
7979
self.dogstatsd_url or ddtrace.internal.agent.get_stats_url()
8080
)
81-
self.tracer: Optional[ddtrace.Tracer] = tracer
81+
self.tracer: Optional[ddtrace._trace.tracer.Tracer] = tracer
8282
self._runtime_metrics: RuntimeMetrics = RuntimeMetrics()
8383
self._services: Set[str] = set()
8484

@@ -114,7 +114,7 @@ def _restart(cls):
114114

115115
@classmethod
116116
def enable(cls, flush_interval=None, tracer=None, dogstatsd_url=None):
117-
# type: (Optional[float], Optional[ddtrace.Tracer], Optional[str]) -> None
117+
# type: (Optional[float], Optional[ddtrace._trace.tracer.Tracer], Optional[str]) -> None
118118
with cls._lock:
119119
if cls._instance is not None:
120120
return

ddtrace/internal/runtime/tag_collectors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class RuntimeTagCollector(ValueCollector):
1717

1818

1919
class TracerTagCollector(RuntimeTagCollector):
20-
"""Tag collector for the ddtrace Tracer"""
20+
"""Tag collector for the ddtrace._trace.tracer.Tracer"""
2121

2222
required_modules = ["ddtrace"]
2323

ddtrace/llmobs/_llmobs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ def enable(
298298
api_key: Optional[str] = None,
299299
env: Optional[str] = None,
300300
service: Optional[str] = None,
301-
_tracer: Optional[ddtrace.Tracer] = None,
301+
_tracer: Optional[ddtrace._trace.tracer.Tracer] = None,
302302
) -> None:
303303
"""
304304
Enable LLM Observability tracing.

ddtrace/profiling/collector/stack.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ import ddtrace
44
from ddtrace.profiling import collector
55

66
class StackCollector(collector.PeriodicCollector):
7-
tracer: typing.Optional[ddtrace.Tracer]
7+
tracer: typing.Optional[ddtrace._trace.tracer.Tracer]

ddtrace/profiling/exporter/http.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class PprofHTTPExporter(pprof.PprofExporter):
4040

4141
def __init__(
4242
self,
43-
tracer: ddtrace.Tracer = ddtrace.tracer,
43+
tracer: ddtrace._trace.tracer.Tracer = ddtrace.tracer,
4444
enable_code_provenance: bool = True,
4545
api_key: typing.Optional[str] = None,
4646
timeout: float = config.api_timeout,

ddtrace/runtime/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class RuntimeMetrics(metaclass=_RuntimeMetricsStatus):
2626

2727
@staticmethod
2828
def enable(tracer=None, dogstatsd_url=None, flush_interval=None):
29-
# type: (Optional[ddtrace.Tracer], Optional[str], Optional[float]) -> None
29+
# type: (Optional[ddtrace._trace.tracer.Tracer], Optional[str], Optional[float]) -> None
3030
"""
3131
Enable the runtime metrics collection service.
3232

0 commit comments

Comments
 (0)