Skip to content

Commit 7e17b31

Browse files
Fix tests
1 parent 505e0c0 commit 7e17b31

File tree

2 files changed

+28
-3
lines changed

2 files changed

+28
-3
lines changed

dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/user/AppSecEventTrackerSpecification.groovy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,6 @@ class AppSecEventTrackerSpecification extends DDSpecification {
496496
drain()
497497
}
498498
final expectedTags = ["event_type:${event.getTag()}".toString(), "sdk_version:${version.getTag()}".toString()]
499-
assert metrics.size() == 1
500499
final metric = metrics.find { it.metricName == 'sdk.event'}
501500
assert metric != null
502501
assert metric.namespace == 'appsec'

dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/user/EventTrackerAppSecDisabledForkedTest.groovy

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.datadog.appsec.user
22

3+
import datadog.appsec.api.login.EventTrackerV2
34
import datadog.appsec.api.user.User
45
import datadog.trace.api.GlobalTracer
56
import datadog.trace.api.UserIdCollectionMode
@@ -26,6 +27,7 @@ class EventTrackerAppSecDisabledForkedTest extends DDSpecification {
2627
void setup() {
2728
tracker = new AppSecEventTracker()
2829
GlobalTracer.setEventTracker(tracker)
30+
EventTrackerV2.setEventTrackerService(tracker)
2931
User.setUserService(tracker)
3032
traceSegment = Mock(TraceSegment)
3133
final tracer = Stub(AgentTracer.TracerAPI) {
@@ -40,15 +42,15 @@ class EventTrackerAppSecDisabledForkedTest extends DDSpecification {
4042
GlobalTracer.getEventTracker().trackLoginSuccessEvent('user', ['key1': 'value1', 'key2': 'value2'])
4143
4244
then:
43-
1 * traceSegment.setTagTop('_dd.appsec.events.users.login.success.sdk', true)
45+
1 * traceSegment.setTagTop('_dd.appsec.events.users.login.success.sdk', true, true)
4446
}
4547
4648
void 'test track login failure event (SDK)'() {
4749
when:
4850
GlobalTracer.getEventTracker().trackLoginFailureEvent('user', true, ['key1': 'value1', 'key2': 'value2'])
4951
5052
then:
51-
1 * traceSegment.setTagTop('_dd.appsec.events.users.login.failure.sdk', true)
53+
1 * traceSegment.setTagTop('_dd.appsec.events.users.login.failure.sdk', true, true)
5254
}
5355
5456
void 'test track custom event (SDK)'() {
@@ -59,6 +61,30 @@ class EventTrackerAppSecDisabledForkedTest extends DDSpecification {
5961
1 * traceSegment.setTagTop('_dd.appsec.events.myevent.sdk', true, true)
6062
}
6163
64+
void 'test track login success event V2 (SDK)'() {
65+
when:
66+
EventTrackerV2.trackUserLoginSuccess('user', 'id', ['key1': 'value1', 'key2': 'value2'])
67+
68+
then:
69+
1 * traceSegment.setTagTop('_dd.appsec.events.users.login.success.sdk', true, true)
70+
}
71+
72+
void 'test track login failure event V2 (SDK)'() {
73+
when:
74+
EventTrackerV2.trackUserLoginFailure('user', true, ['key1': 'value1', 'key2': 'value2'])
75+
76+
then:
77+
1 * traceSegment.setTagTop('_dd.appsec.events.users.login.failure.sdk', true, true)
78+
}
79+
80+
void 'test track custom event V2 (SDK)'() {
81+
when:
82+
EventTrackerV2.trackCustomEvent('myevent', ['key1': 'value1', 'key2': 'value2'])
83+
84+
then:
85+
1 * traceSegment.setTagTop('_dd.appsec.events.myevent.sdk', true, true)
86+
}
87+
6288
void 'test onSignup'() {
6389
when:
6490
tracker.onSignupEvent(IDENTIFICATION, 'user', ['key1': 'value1', 'key2': 'value2'])

0 commit comments

Comments
 (0)