Skip to content
This repository was archived by the owner on May 6, 2025. It is now read-only.

Conversation

@estringana
Copy link
Collaborator

Description

Improve output of phpinfo regarding remote config status

Motivation

Additional Notes

Describe how to test your changes

Readiness checklist

  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected
  • All new source files include the required notice

Release checklist

  • The CHANGELOG.md has been updated

@estringana estringana requested a review from Anilm3 May 10, 2023 14:58
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #259 (e9a8f3f) into master (00228ee) will increase coverage by 8.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   63.67%   72.04%   +8.36%     
==========================================
  Files          94       25      -69     
  Lines        5688     3241    -2447     
  Branches     1829      723    -1106     
==========================================
- Hits         3622     2335    -1287     
+ Misses        988      540     -448     
+ Partials     1078      366     -712     
Flag Coverage Δ
extension 72.04% <100.00%> (+0.40%) ⬆️
helper ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/extension/ddappsec.c 77.25% <100.00%> (+5.57%) ⬆️

... and 69 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@estringana estringana force-pushed the estringana/improve-phpinfo-output branch from b0c72e3 to e9a8f3f Compare May 11, 2023 07:29
Copy link
Collaborator

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estringana estringana merged commit 51391a5 into master May 11, 2023
@estringana estringana deleted the estringana/improve-phpinfo-output branch May 11, 2023 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants