Skip to content

Commit 2b8d31d

Browse files
authored
feat: ddtrace py now sets a default sample rate header, so we don't fall into this case anymore (#428)
1 parent d481a72 commit 2b8d31d

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

tests/test_tracing.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,17 +184,14 @@ def test_with_non_object_event(self):
184184
{},
185185
)
186186

187-
"""
188-
TODO(astuyve) I don't think partial extraction is forbidden anymore? ask rey
189187
@with_trace_propagation_style("datadog")
190188
def test_with_incomplete_datadog_trace_headers(self):
191189
lambda_ctx = get_mock_context()
192190
ctx, source, event_source = extract_dd_trace_context(
193-
{"headers": {TraceHeader.TRACE_ID: "123", TraceHeader.PARENT_ID: "321"}},
191+
{"headers": {TraceHeader.TRACE_ID: "123"}},
194192
lambda_ctx,
195193
)
196194
self.assertEqual(source, "xray")
197-
print(ctx)
198195
self.assertEqual(
199196
ctx,
200197
Context(
@@ -211,7 +208,6 @@ def test_with_incomplete_datadog_trace_headers(self):
211208
TraceHeader.SAMPLING_PRIORITY: "2",
212209
},
213210
)
214-
"""
215211

216212
@with_trace_propagation_style("datadog")
217213
def test_with_complete_datadog_trace_headers(self):
@@ -532,7 +528,6 @@ def test_with_legacy_client_context_w3c_trace_data(self):
532528
"_dd.parent_id": "0000000000000000",
533529
},
534530
)
535-
print(ctx)
536531
self.assertEqual(ctx, expected_context)
537532
self.assertDictEqual(
538533
get_dd_trace_context(),

0 commit comments

Comments
 (0)