-
Notifications
You must be signed in to change notification settings - Fork 14
Malformed _X_AMZN_TRACE_ID value #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We're also experiencing this. Seems like AWS added a new field overnight to the tracing environment variable. |
Hi, thanks for reaching out! It does look like this is a change to AWS X-Ray. That said, this library is now deprecated, and no longer needed. There is an upgrade guide available in the documentation. Please let me know if you have issues upgrading. Thanks! |
I have a fix, sadly issues pushing a branch gives me a 403, tried many things. And since there's an upgrade possible, I'll just post the .patch file here, should anybody need it. This code requires at least 3 parts in the trace, any higher number is allowed too. ------- Patch starts below this line ------------------------------
|
Hi astuyve, we have currently a setup that prevents us from migrating to the new lambda extension solution.
We therefore like to know, if there is an alternative way to obtain the files we need to install to /opts/? E.g. by downloading a .tar file? |
Hi @dataGeeek! Thanks for the question. For container-image based services, we have a different documentation page which should handle your use case. Thanks! |
Hi @astuyve, unfortunately the proposed solution for container-image based services does not work out-of-the-box for us, because jib does not support the Therefore I'm asking if there is a nother way to fetch the necessary files and place them in the docker container? Thanks for your support! |
Given a user cannot upgrade, we've decided it's best to backport a fix to this library. I'll update this ticket when we perform the release, thanks everyone! |
Hi folks, This is fix is released in 1.4.10. Thanks! |
Overnight we've suddently started to see
Malformed _X_AMZN_TRACE_ID
errors.As an example the value we're seeing is:
Root=1-46105bdf-04c13a9504458ebc539f5fba;Parent=240a548a42a88af4;Sampled=0;Lineage=12326a9d:0
Looks like lineage is valid (https://docs.aws.amazon.com/xray/latest/devguide/xray-concepts.html#xray-concepts-tracingheader) however this library is throwing an error when it splits the traceId by
;
. See here:datadog-lambda-java/src/main/java/com/datadoghq/datadog_lambda_java/Tracing.java
Line 397 in 7f1c919
Not sure I can prevent the lineage property appearing in traceIds but should this library handle this case?
The text was updated successfully, but these errors were encountered: