chore: fix clippy

Author: apiarian-datadog

.github/workflows/rs_ci.yml

@@ -76,8 +76,11 @@ jobs:
           components: clippy
           cache: false
       - uses: mozilla-actions/[email protected]
+      # We need to do these separately because the fips feature is incompatible with the default feature.
       - working-directory: bottlecap
-        run: cargo clippy --workspace --all-features
+        run: cargo clippy --workspace --features default
+      - working-directory: bottlecap
+        run: cargo clippy --workspace --no-default-features --features fips
 
   build-all:
     name: Build All

.gitlab/templates/pipeline.yaml.tpl

@@ -39,7 +39,10 @@ cargo clippy:
   needs: []
   script:
     - apt-get update && apt-get install -y --fix-missing --no-install-recommends golang-go
-    - cd bottlecap && cargo clippy --workspace --all-features
+    - cd bottlecap
+    # We need to do these separately because the fips feature is incompatible with the default feature.
+    - cargo clippy --workspace --features default
+    - cargo clippy --workspace --no-default-features --features fips
 
 {{ range $flavor := (ds "flavors").flavors }}
 

bottlecap/src/bin/bottlecap/main.rs

@@ -102,6 +102,8 @@ fn prepare_client_provider() -> Result<()> {
 }
 
 #[cfg(not(feature = "fips"))]
+// this is not unnecessary since the fips version can return an error
+#[allow(clippy::unnecessary_wraps)]
 fn prepare_client_provider() -> Result<()> {
     // No-op in non-FIPS mode
     Ok(())