♻️ Remove cookieOptions from configuration

Author: yannickadam

packages/core/src/domain/configuration/configuration.spec.ts

@@ -6,7 +6,7 @@ import {
   resetExperimentalFeatures,
 } from '../../tools/experimentalFeatures'
 import type { InitConfiguration } from './configuration'
-import { validateAndBuildConfiguration } from './configuration'
+import { buildCookieOptions, validateAndBuildConfiguration } from './configuration'
 
 describe('validateAndBuildConfiguration', () => {
   const clientToken = 'some_client_token'
@@ -117,25 +117,25 @@ describe('validateAndBuildConfiguration', () => {
     })
   })
 
-  describe('cookie options', () => {
+  describe('build cookie options', () => {
     it('should not be secure nor crossSite by default', () => {
-      const configuration = validateAndBuildConfiguration({ clientToken })!
-      expect(configuration.cookieOptions).toEqual({ secure: false, crossSite: false })
+      const cookieOptions = buildCookieOptions({ clientToken })!
+      expect(cookieOptions).toEqual({ secure: false, crossSite: false })
     })
 
     it('should be secure when `useSecureSessionCookie` is truthy', () => {
-      const configuration = validateAndBuildConfiguration({ clientToken, useSecureSessionCookie: true })!
-      expect(configuration.cookieOptions).toEqual({ secure: true, crossSite: false })
+      const cookieOptions = buildCookieOptions({ clientToken, useSecureSessionCookie: true })!
+      expect(cookieOptions).toEqual({ secure: true, crossSite: false })
     })
 
     it('should be secure and crossSite when `useCrossSiteSessionCookie` is truthy', () => {
-      const configuration = validateAndBuildConfiguration({ clientToken, useCrossSiteSessionCookie: true })!
-      expect(configuration.cookieOptions).toEqual({ secure: true, crossSite: true })
+      const cookieOptions = buildCookieOptions({ clientToken, useCrossSiteSessionCookie: true })!
+      expect(cookieOptions).toEqual({ secure: true, crossSite: true })
     })
 
     it('should have domain when `trackSessionAcrossSubdomains` is truthy', () => {
-      const configuration = validateAndBuildConfiguration({ clientToken, trackSessionAcrossSubdomains: true })!
-      expect(configuration.cookieOptions).toEqual({ secure: false, crossSite: false, domain: jasmine.any(String) })
+      const cookieOptions = buildCookieOptions({ clientToken, trackSessionAcrossSubdomains: true })!
+      expect(cookieOptions).toEqual({ secure: false, crossSite: false, domain: jasmine.any(String) })
     })
   })
 

packages/core/src/domain/configuration/configuration.ts

@@ -78,7 +78,6 @@ interface ReplicaUserConfiguration {
 export interface Configuration extends TransportConfiguration {
   // Built from init configuration
   beforeSend: GenericBeforeSendCallback | undefined
-  cookieOptions: CookieOptions
   allowFallbackToLocalStorage: boolean
   sessionStoreStorage: SessionStoreStorage | undefined
   sessionSampleRate: number
@@ -140,7 +139,6 @@ export function validateAndBuildConfiguration(initConfiguration: InitConfigurati
     {
       beforeSend:
         initConfiguration.beforeSend && catchUserErrors(initConfiguration.beforeSend, 'beforeSend threw an error:'),
-      cookieOptions: buildCookieOptions(initConfiguration),
       allowFallbackToLocalStorage,
       sessionStoreStorage,
       sessionSampleRate: sessionSampleRate ?? 100,