Stop passing font size to DevTools

Fixes #5406

Author: DanTup

src/extension/sdk/dev_tools/embedded_view.ts

@@ -16,14 +16,11 @@ function getTheme() {
 	const isDarkMode = !document.body.classList.contains('vscode-light');
 	const backgroundColor = currentBackgroundColor = getComputedStyle(document.documentElement).getPropertyValue('--vscode-editor-background');
 	const foregroundColor = getComputedStyle(document.documentElement).getPropertyValue('--vscode-editor-foreground');
-	const fontSizeWithUnits = getComputedStyle(document.documentElement).getPropertyValue('--vscode-editor-font-size');
-	const fontSize = fontSizeWithUnits && fontSizeWithUnits.endsWith('px') ? parseFloat(fontSizeWithUnits) : undefined;
 
 	return {
 		isDarkMode: isDarkMode,
 		backgroundColor: backgroundColor,
 		foregroundColor: foregroundColor,
-		fontSize: fontSize,
 	};
 }
 
@@ -45,9 +42,6 @@ window.addEventListener('message', (event) => {
 			// Don't include # in colors
 			// https://github.com/flutter/flutter/issues/155992
 			let url = \`\${message.url}&theme=\${themeKind}&backgroundColor=\${encodeURIComponent(theme.backgroundColor?.replace('#', ''))}&foregroundColor=\${encodeURIComponent(theme.foregroundColor?.replace('#', ''))}\`;
-			if (theme.fontSize) {
-				url += \`&fontSize=\${encodeURIComponent(theme.fontSize)}\`;
-			}
 			if (devToolsFrame.src !== url) {
 				devToolsFrame.src = url;
 				vscode.setState({ frameUrl: url });

src/extension/views/devtools/base_view_provider.ts

@@ -60,14 +60,11 @@ export abstract class MyBaseWebViewProvider implements vs.WebviewViewProvider {
 		const isDarkMode = !document.body.classList.contains('vscode-light');
 		const backgroundColor = currentBackgroundColor = getComputedStyle(document.documentElement).getPropertyValue('--vscode-sideBar-background');
 		const foregroundColor = getComputedStyle(document.documentElement).getPropertyValue('--vscode-sideBar-foreground');
-		const fontSizeWithUnits = getComputedStyle(document.documentElement).getPropertyValue('--vscode-editor-font-size');
-		const fontSize = fontSizeWithUnits && fontSizeWithUnits.endsWith('px') ? parseFloat(fontSizeWithUnits) : undefined;
 
 		return {
 			isDarkMode: isDarkMode,
 			backgroundColor: backgroundColor,
 			foregroundColor: foregroundColor,
-			fontSize: fontSize,
 		};
 	}
 
@@ -86,10 +83,6 @@ export abstract class MyBaseWebViewProvider implements vs.WebviewViewProvider {
 				// Don't include # in colors
 				// https://github.com/flutter/flutter/issues/155992
 				let url = \`\${message.url}\${qsSep}${embedFlags}&theme=\${theme}&backgroundColor=\${encodeURIComponent(background?.replace('#', ''))}&foregroundColor=\${encodeURIComponent(foreground?.replace('#', ''))}\`;
-				const fontSizeWithUnits = getComputedStyle(document.documentElement).getPropertyValue('--vscode-editor-font-size');
-				if (fontSizeWithUnits && fontSizeWithUnits.endsWith('px')) {
-					url += \`&fontSize=\${encodeURIComponent(parseFloat(fontSizeWithUnits))}\`;
-				}
 				if (devToolsFrame.src !== url)
 					devToolsFrame.src = url;
 				return;

src/extension/views/devtools/legacy_post_message_sidebar/sidebar.ts

@@ -75,10 +75,6 @@ class MyWebViewProvider implements vs.WebviewViewProvider, IAmDisposable {
 			// Don't include # in colors
 			// https://github.com/flutter/flutter/issues/155992
 			let url = \`\${currentBaseUrl}\${qsSep}${embedFlags}&theme=\${theme}&backgroundColor=\${encodeURIComponent(background?.replace('#', ''))}&foregroundColor=\${encodeURIComponent(foreground?.replace('#', ''))}\`;
-			const fontSizeWithUnits = getComputedStyle(document.documentElement).getPropertyValue('--vscode-editor-font-size');
-			if (fontSizeWithUnits && fontSizeWithUnits.endsWith('px')) {
-				url += \`&fontSize=\${encodeURIComponent(parseFloat(fontSizeWithUnits))}\`;
-			}
 			if (devToolsFrame.src !== url)
 				devToolsFrame.src = url;
 		}