fix: add non-null version to ReactNativeInfo #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Author
|
RFC: what version should we use here? I figured the ideal version would be to use the actual running react native version, which react native does not expose in the global setup or the navigator setup. In a perfect world, they would be able to set the current running react native version somewhere and we read it in, but I don't think they do that. |
Author
|
I was able to patch in a version to react native like so: This begs the question - should I open a PR with React Native to get this detection working from global.process.version so we can use that here? That might be a longer-term solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing with amazon-chime-sdk-js, the react-native browser detection caused an error documented in this issue: aws/amazon-chime-sdk-js#1856. This PR adds a default version based on the version here, which gets replaced when they cut a new version
https://github.com/facebook/react-native/blob/09b69036c023ccab47b7c5b950247217bb975686/package.json#L4