diff --git a/alb-internal.tf b/alb-internal.tf index 61ddcac..e370a31 100644 --- a/alb-internal.tf +++ b/alb-internal.tf @@ -27,8 +27,7 @@ resource "aws_lb" "ecs_internal" { tags = merge( var.tags, { - "Terraform" = true, - Name = "ecs-${var.name}-internal" + Name = "ecs-${var.name}-internal" }, ) } @@ -47,12 +46,7 @@ resource "aws_lb_listener" "ecs_https_internal" { target_group_arn = aws_lb_target_group.ecs_default_https_internal[0].arn } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = var.tags } resource "aws_lb_listener" "ecs_test_https_internal" { @@ -69,12 +63,7 @@ resource "aws_lb_listener" "ecs_test_https_internal" { #target_group_arn = aws_lb_target_group.ecs_replacement_https[0].arn target_group_arn = aws_lb_target_group.ecs_default_https_internal[0].arn } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = var.tags } # Generate a random string to add it to the name of the Target Group @@ -92,17 +81,9 @@ resource "aws_lb_target_group" "ecs_default_https_internal" { port = 80 protocol = "HTTP" vpc_id = var.vpc_id - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = var.tags lifecycle { create_before_destroy = true } } - - - diff --git a/alb.tf b/alb.tf index 258e5bd..f11f981 100644 --- a/alb.tf +++ b/alb.tf @@ -24,13 +24,9 @@ resource "aws_lb" "ecs" { } } - tags = merge( - var.tags, - { - "Terraform" = true, - "Name" = "ecs-${var.name}" - }, - ) + tags = merge(var.tags, { + "Name" = "ecs-${var.name}" + }) } resource "aws_lb_listener" "ecs_https" { @@ -47,12 +43,7 @@ resource "aws_lb_listener" "ecs_https" { target_group_arn = aws_lb_target_group.ecs_default_https[0].arn } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = var.tags } resource "aws_lb_listener" "ecs_http_redirect" { @@ -71,12 +62,7 @@ resource "aws_lb_listener" "ecs_http_redirect" { status_code = "HTTP_301" } } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = var.tags } resource "aws_lb_listener" "ecs_test_https" { @@ -93,12 +79,7 @@ resource "aws_lb_listener" "ecs_test_https" { #target_group_arn = aws_lb_target_group.ecs_replacement_https[0].arn target_group_arn = aws_lb_target_group.ecs_default_https[0].arn } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = var.tags } resource "aws_lb_listener" "ecs_test_http_redirect" { @@ -117,12 +98,7 @@ resource "aws_lb_listener" "ecs_test_http_redirect" { status_code = "HTTP_301" } } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = var.tags } # Generate a random string to add it to the name of the Target Group @@ -140,12 +116,9 @@ resource "aws_lb_target_group" "ecs_default_http" { protocol = "HTTP" vpc_id = var.vpc_id - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + Name = replace(substr("ecs-${var.name}-default-http-${random_string.alb_prefix.result}", 0, 32), "/-+$/", "") + }) lifecycle { create_before_destroy = true @@ -160,12 +133,9 @@ resource "aws_lb_target_group" "ecs_default_https" { protocol = "HTTP" vpc_id = var.vpc_id - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + Name = replace(substr("ecs-${var.name}-default-https-${random_string.alb_prefix.result}", 0, 32), "/-+$/", "") + }) lifecycle { create_before_destroy = true diff --git a/cloutwatch-alarms-alb.tf b/cloutwatch-alarms-alb.tf index 8ba70fc..ba89cf8 100644 --- a/cloutwatch-alarms-alb.tf +++ b/cloutwatch-alarms-alb.tf @@ -15,12 +15,9 @@ resource "aws_cloudwatch_metric_alarm" "alb_500_errors" { insufficient_data_actions = [] treat_missing_data = "ignore" - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + Name = "${try(data.aws_iam_account_alias.current[0].account_alias, var.alarm_prefix)}-ecs-${var.name}-alb-500-errors" + }) dimensions = { LoadBalancer = aws_lb.ecs[0].arn_suffix } @@ -43,12 +40,9 @@ resource "aws_cloudwatch_metric_alarm" "alb_400_errors" { insufficient_data_actions = [] treat_missing_data = "ignore" - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + Name = "${try(data.aws_iam_account_alias.current[0].account_alias, var.alarm_prefix)}-ecs-${var.name}-alb-400-errors" + }) dimensions = { LoadBalancer = aws_lb.ecs[0].arn_suffix } @@ -88,10 +82,7 @@ resource "aws_cloudwatch_metric_alarm" "alb_latency" { } } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + Name = "${try(data.aws_iam_account_alias.current[0].account_alias, var.alarm_prefix)}-ecs-${var.name}-alb-latency" + }) } diff --git a/cloutwatch-alarms-asg.tf b/cloutwatch-alarms-asg.tf index 5963ee9..456b267 100644 --- a/cloutwatch-alarms-asg.tf +++ b/cloutwatch-alarms-asg.tf @@ -19,10 +19,7 @@ resource "aws_cloudwatch_metric_alarm" "asg_high_cpu" { AutoScalingGroupName = aws_autoscaling_group.ecs[0].name } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + Name = "${try(data.aws_iam_account_alias.current[0].account_alias, var.alarm_prefix)}-ecs-${var.name}-asg-high-cpu" + }) } diff --git a/cloutwatch-alarms-ecs.tf b/cloutwatch-alarms-ecs.tf index 48ff9ad..43e7916 100644 --- a/cloutwatch-alarms-ecs.tf +++ b/cloutwatch-alarms-ecs.tf @@ -19,12 +19,9 @@ resource "aws_cloudwatch_metric_alarm" "ecs_high_memory" { ClusterName = aws_ecs_cluster.ecs.name } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + Name = "${try(data.aws_iam_account_alias.current[0].account_alias, var.alarm_prefix)}-ecs-${var.name}-high-memory" + }) } resource "aws_cloudwatch_metric_alarm" "ecs_high_cpu" { @@ -48,10 +45,7 @@ resource "aws_cloudwatch_metric_alarm" "ecs_high_cpu" { ClusterName = aws_ecs_cluster.ecs.name } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + Name = "${try(data.aws_iam_account_alias.current[0].account_alias, var.alarm_prefix)}-ecs-${var.name}-high-cpu" + }) } diff --git a/cloutwatch-alarms-efs.tf b/cloutwatch-alarms-efs.tf index ea7c278..e7505c8 100644 --- a/cloutwatch-alarms-efs.tf +++ b/cloutwatch-alarms-efs.tf @@ -19,10 +19,6 @@ resource "aws_cloudwatch_metric_alarm" "efs_credits_low" { FileSystemId = aws_efs_file_system.ecs[0].id } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + }) } diff --git a/ec2-launch-template.tf b/ec2-launch-template.tf index 1120c93..34de7ee 100644 --- a/ec2-launch-template.tf +++ b/ec2-launch-template.tf @@ -33,12 +33,8 @@ resource "aws_launch_template" "ecs" { create_before_destroy = true } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + }) } resource "tls_private_key" "algorithm" { @@ -53,10 +49,6 @@ resource "aws_key_pair" "generated_key" { key_name = "${var.name}-key" public_key = tls_private_key.algorithm[0].public_key_openssh - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + }) } diff --git a/ecs.tf b/ecs.tf index b0efef3..5b1e3b1 100644 --- a/ecs.tf +++ b/ecs.tf @@ -6,15 +6,11 @@ resource "aws_ecs_cluster" "ecs" { value = var.container_insights ? "enabled" : "disabled" } - tags = merge( - var.tags, - { - "Terraform" = true - }, - ) + tags = merge(var.tags, { + }) lifecycle { ignore_changes = [] - + } } diff --git a/efs.tf b/efs.tf index e8f620e..4e5ae81 100644 --- a/efs.tf +++ b/efs.tf @@ -21,13 +21,10 @@ resource "aws_efs_file_system" "ecs" { } } - tags = merge( - var.tags, - { - Name = "ecs-${var.name}" - Backup = var.backup - }, - ) + tags = merge(var.tags, { + Name = "ecs-${var.name}" + Backup = var.backup + }) # lifecycle { # prevent_destroy = true @@ -54,14 +51,11 @@ resource "aws_security_group" "efs" { description = "for EFS to talk to ECS cluster" vpc_id = var.vpc_id - - tags = merge( - var.tags, - { - Name = "ecs-efs-${var.name}" - Backup = var.backup - }, - ) + + tags = merge(var.tags, { + Name = "ecs-efs-${var.name}" + Backup = var.backup + }) } resource "aws_security_group_rule" "nfs_from_ecs_to_efs" { diff --git a/iam-codedeploy.tf b/iam-codedeploy.tf index 8c0ba0a..aa9e54d 100644 --- a/iam-codedeploy.tf +++ b/iam-codedeploy.tf @@ -1,12 +1,8 @@ resource "aws_iam_role" "codedeploy_service" { count = var.code_deploy ? 1 : 0 name = "codedeploy-service-${var.name}-${data.aws_region.current.name}" - tags = merge( - var.tags, - { - "terraform" = "true" - }, - ) + tags = merge(var.tags, { + }) assume_role_policy = <