From afc6ad6a84c3c8725b70299b0495b3fd58c3546e Mon Sep 17 00:00:00 2001 From: AlyssaCote Date: Thu, 29 Aug 2024 18:44:00 -0500 Subject: [PATCH 1/4] all file names snake case --- ex/high_throughput_inference/mock_app.py | 2 +- .../standalone_workermanager.py | 14 +++++++------- .../{dragonchannel.py => dragon_channel.py} | 0 .../channel/{dragonfli.py => dragon_fli.py} | 0 .../{devicemanager.py => device_manager.py} | 2 +- ...uestdispatcher.py => request_dispatcher.py} | 6 +++--- .../{workermanager.py => worker_manager.py} | 8 ++++---- ...ironmentloader.py => environment_loader.py} | 2 +- ...featurestore.py => dragon_feature_store.py} | 2 +- .../{featurestore.py => feature_store.py} | 0 .../_core/mli/infrastructure/worker/worker.py | 2 +- tests/dragon/featurestore.py | 2 +- .../test_core_machine_learning_worker.py | 2 +- tests/dragon/test_device_manager.py | 4 ++-- tests/dragon/test_environment_loader.py | 8 ++++---- tests/dragon/test_error_handling.py | 18 +++++++++--------- tests/dragon/test_reply_building.py | 2 +- tests/dragon/test_request_dispatcher.py | 12 ++++++------ tests/dragon/test_torch_worker.py | 2 +- tests/dragon/test_worker_manager.py | 8 ++++---- tests/mli/featurestore.py | 2 +- 21 files changed, 49 insertions(+), 49 deletions(-) rename smartsim/_core/mli/comm/channel/{dragonchannel.py => dragon_channel.py} (100%) rename smartsim/_core/mli/comm/channel/{dragonfli.py => dragon_fli.py} (100%) rename smartsim/_core/mli/infrastructure/control/{devicemanager.py => device_manager.py} (98%) rename smartsim/_core/mli/infrastructure/control/{requestdispatcher.py => request_dispatcher.py} (99%) rename smartsim/_core/mli/infrastructure/control/{workermanager.py => worker_manager.py} (98%) rename smartsim/_core/mli/infrastructure/{environmentloader.py => environment_loader.py} (98%) rename smartsim/_core/mli/infrastructure/storage/{dragonfeaturestore.py => dragon_feature_store.py} (98%) rename smartsim/_core/mli/infrastructure/storage/{featurestore.py => feature_store.py} (100%) diff --git a/ex/high_throughput_inference/mock_app.py b/ex/high_throughput_inference/mock_app.py index 517d18fb2f..dcc52296ef 100644 --- a/ex/high_throughput_inference/mock_app.py +++ b/ex/high_throughput_inference/mock_app.py @@ -43,7 +43,7 @@ import torch from mpi4py import MPI -from smartsim._core.mli.infrastructure.storage.dragonfeaturestore import ( +from smartsim._core.mli.infrastructure.storage.dragon_feature_store import ( DragonFeatureStore, ) from smartsim._core.mli.message_handler import MessageHandler diff --git a/ex/high_throughput_inference/standalone_workermanager.py b/ex/high_throughput_inference/standalone_workermanager.py index 0b8c61251b..feb1af1aee 100644 --- a/ex/high_throughput_inference/standalone_workermanager.py +++ b/ex/high_throughput_inference/standalone_workermanager.py @@ -58,17 +58,17 @@ from smartsim._core.entrypoints.service import Service from smartsim._core.mli.comm.channel.channel import CommChannelBase -from smartsim._core.mli.comm.channel.dragonchannel import DragonCommChannel -from smartsim._core.mli.comm.channel.dragonfli import DragonFLIChannel -from smartsim._core.mli.infrastructure.storage.dragonfeaturestore import ( +from smartsim._core.mli.comm.channel.dragon_channel import DragonCommChannel +from smartsim._core.mli.comm.channel.dragon_fli import DragonFLIChannel +from smartsim._core.mli.infrastructure.storage.dragon_feature_store import ( DragonFeatureStore, ) -from smartsim._core.mli.infrastructure.control.requestdispatcher import ( +from smartsim._core.mli.infrastructure.control.request_dispatcher import ( RequestDispatcher, ) -from smartsim._core.mli.infrastructure.control.workermanager import WorkerManager -from smartsim._core.mli.infrastructure.environmentloader import EnvironmentConfigLoader -from smartsim._core.mli.infrastructure.storage.dragonfeaturestore import ( +from smartsim._core.mli.infrastructure.control.worker_manager import WorkerManager +from smartsim._core.mli.infrastructure.environment_loader import EnvironmentConfigLoader +from smartsim._core.mli.infrastructure.storage.dragon_feature_store import ( DragonFeatureStore, ) from smartsim._core.mli.infrastructure.worker.worker import MachineLearningWorkerBase diff --git a/smartsim/_core/mli/comm/channel/dragonchannel.py b/smartsim/_core/mli/comm/channel/dragon_channel.py similarity index 100% rename from smartsim/_core/mli/comm/channel/dragonchannel.py rename to smartsim/_core/mli/comm/channel/dragon_channel.py diff --git a/smartsim/_core/mli/comm/channel/dragonfli.py b/smartsim/_core/mli/comm/channel/dragon_fli.py similarity index 100% rename from smartsim/_core/mli/comm/channel/dragonfli.py rename to smartsim/_core/mli/comm/channel/dragon_fli.py diff --git a/smartsim/_core/mli/infrastructure/control/devicemanager.py b/smartsim/_core/mli/infrastructure/control/device_manager.py similarity index 98% rename from smartsim/_core/mli/infrastructure/control/devicemanager.py rename to smartsim/_core/mli/infrastructure/control/device_manager.py index 3570bd51ed..54d58507ee 100644 --- a/smartsim/_core/mli/infrastructure/control/devicemanager.py +++ b/smartsim/_core/mli/infrastructure/control/device_manager.py @@ -28,7 +28,7 @@ from contextlib import _GeneratorContextManager, contextmanager from .....log import get_logger -from ...infrastructure.storage.featurestore import FeatureStore +from ..storage.feature_store import FeatureStore from ..worker.worker import MachineLearningWorkerBase, RequestBatch logger = get_logger(__name__) diff --git a/smartsim/_core/mli/infrastructure/control/requestdispatcher.py b/smartsim/_core/mli/infrastructure/control/request_dispatcher.py similarity index 99% rename from smartsim/_core/mli/infrastructure/control/requestdispatcher.py rename to smartsim/_core/mli/infrastructure/control/request_dispatcher.py index d56912a8f0..513dc5f639 100644 --- a/smartsim/_core/mli/infrastructure/control/requestdispatcher.py +++ b/smartsim/_core/mli/infrastructure/control/request_dispatcher.py @@ -47,9 +47,9 @@ from .....error import SmartSimError from .....log import get_logger from ....utils.timings import PerfTimer -from ...infrastructure.environmentloader import EnvironmentConfigLoader -from ...infrastructure.storage.featurestore import FeatureStore -from ...infrastructure.worker.worker import ( +from ..environment_loader import EnvironmentConfigLoader +from ..storage.feature_store import FeatureStore +from ..worker.worker import ( InferenceRequest, MachineLearningWorkerBase, ModelIdentifier, diff --git a/smartsim/_core/mli/infrastructure/control/workermanager.py b/smartsim/_core/mli/infrastructure/control/worker_manager.py similarity index 98% rename from smartsim/_core/mli/infrastructure/control/workermanager.py rename to smartsim/_core/mli/infrastructure/control/worker_manager.py index 54a245b813..64e831f2a0 100644 --- a/smartsim/_core/mli/infrastructure/control/workermanager.py +++ b/smartsim/_core/mli/infrastructure/control/worker_manager.py @@ -38,20 +38,20 @@ import typing as t from queue import Empty -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStore +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStore from .....log import get_logger from ....entrypoints.service import Service from ....utils.timings import PerfTimer -from ...infrastructure.environmentloader import EnvironmentConfigLoader -from ...infrastructure.worker.worker import ( +from ..environment_loader import EnvironmentConfigLoader +from ..worker.worker import ( InferenceReply, LoadModelResult, MachineLearningWorkerBase, RequestBatch, ) from ...message_handler import MessageHandler -from .devicemanager import DeviceManager, WorkerDevice +from .device_manager import DeviceManager, WorkerDevice from .error_handling import build_failure_reply, exception_handler if t.TYPE_CHECKING: diff --git a/smartsim/_core/mli/infrastructure/environmentloader.py b/smartsim/_core/mli/infrastructure/environment_loader.py similarity index 98% rename from smartsim/_core/mli/infrastructure/environmentloader.py rename to smartsim/_core/mli/infrastructure/environment_loader.py index 99202ef2ea..c8b158a5ad 100644 --- a/smartsim/_core/mli/infrastructure/environmentloader.py +++ b/smartsim/_core/mli/infrastructure/environment_loader.py @@ -28,7 +28,7 @@ import typing as t from smartsim._core.mli.comm.channel.channel import CommChannelBase -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStore +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStore from smartsim.log import get_logger logger = get_logger(__name__) diff --git a/smartsim/_core/mli/infrastructure/storage/dragonfeaturestore.py b/smartsim/_core/mli/infrastructure/storage/dragon_feature_store.py similarity index 98% rename from smartsim/_core/mli/infrastructure/storage/dragonfeaturestore.py rename to smartsim/_core/mli/infrastructure/storage/dragon_feature_store.py index e89abcd2a2..aee4aac529 100644 --- a/smartsim/_core/mli/infrastructure/storage/dragonfeaturestore.py +++ b/smartsim/_core/mli/infrastructure/storage/dragon_feature_store.py @@ -32,7 +32,7 @@ # isort: on -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStore +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStore from smartsim.error import SmartSimError from smartsim.log import get_logger diff --git a/smartsim/_core/mli/infrastructure/storage/featurestore.py b/smartsim/_core/mli/infrastructure/storage/feature_store.py similarity index 100% rename from smartsim/_core/mli/infrastructure/storage/featurestore.py rename to smartsim/_core/mli/infrastructure/storage/feature_store.py diff --git a/smartsim/_core/mli/infrastructure/worker/worker.py b/smartsim/_core/mli/infrastructure/worker/worker.py index 25e4dc49f7..88c5732f9d 100644 --- a/smartsim/_core/mli/infrastructure/worker/worker.py +++ b/smartsim/_core/mli/infrastructure/worker/worker.py @@ -37,7 +37,7 @@ from .....error import SmartSimError from .....log import get_logger from ...comm.channel.channel import CommChannelBase -from ...infrastructure.storage.featurestore import FeatureStore, FeatureStoreKey +from ..storage.feature_store import FeatureStore, FeatureStoreKey from ...message_handler import MessageHandler from ...mli_schemas.model.model_capnp import Model diff --git a/tests/dragon/featurestore.py b/tests/dragon/featurestore.py index d06035fd70..178b675e64 100644 --- a/tests/dragon/featurestore.py +++ b/tests/dragon/featurestore.py @@ -28,7 +28,7 @@ import typing as t import smartsim.error as sse -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStore +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStore from smartsim.log import get_logger logger = get_logger(__name__) diff --git a/tests/dragon/test_core_machine_learning_worker.py b/tests/dragon/test_core_machine_learning_worker.py index 231a971241..5c931186d7 100644 --- a/tests/dragon/test_core_machine_learning_worker.py +++ b/tests/dragon/test_core_machine_learning_worker.py @@ -34,7 +34,7 @@ import torch import smartsim.error as sse -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStoreKey +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStoreKey from smartsim._core.mli.infrastructure.worker.worker import ( InferenceRequest, MachineLearningWorkerCore, diff --git a/tests/dragon/test_device_manager.py b/tests/dragon/test_device_manager.py index 8edeb60fbb..c58879cb62 100644 --- a/tests/dragon/test_device_manager.py +++ b/tests/dragon/test_device_manager.py @@ -30,11 +30,11 @@ dragon = pytest.importorskip("dragon") -from smartsim._core.mli.infrastructure.control.devicemanager import ( +from smartsim._core.mli.infrastructure.control.device_manager import ( DeviceManager, WorkerDevice, ) -from smartsim._core.mli.infrastructure.storage.featurestore import ( +from smartsim._core.mli.infrastructure.storage.feature_store import ( FeatureStore, FeatureStoreKey, ) diff --git a/tests/dragon/test_environment_loader.py b/tests/dragon/test_environment_loader.py index 8f2716488b..c3331336e5 100644 --- a/tests/dragon/test_environment_loader.py +++ b/tests/dragon/test_environment_loader.py @@ -33,10 +33,10 @@ from dragon.data.ddict.ddict import DDict from dragon.fli import DragonFLIError, FLInterface -from smartsim._core.mli.comm.channel.dragonchannel import DragonCommChannel -from smartsim._core.mli.comm.channel.dragonfli import DragonFLIChannel -from smartsim._core.mli.infrastructure.environmentloader import EnvironmentConfigLoader -from smartsim._core.mli.infrastructure.storage.dragonfeaturestore import ( +from smartsim._core.mli.comm.channel.dragon_channel import DragonCommChannel +from smartsim._core.mli.comm.channel.dragon_fli import DragonFLIChannel +from smartsim._core.mli.infrastructure.environment_loader import EnvironmentConfigLoader +from smartsim._core.mli.infrastructure.storage.dragon_feature_store import ( DragonFeatureStore, ) diff --git a/tests/dragon/test_error_handling.py b/tests/dragon/test_error_handling.py index 0e737101fa..7f823a1c43 100644 --- a/tests/dragon/test_error_handling.py +++ b/tests/dragon/test_error_handling.py @@ -38,20 +38,20 @@ from dragon.fli import FLInterface from dragon.mpbridge.queues import DragonQueue -from smartsim._core.mli.comm.channel.dragonfli import DragonFLIChannel -from smartsim._core.mli.infrastructure.control.devicemanager import WorkerDevice -from smartsim._core.mli.infrastructure.control.requestdispatcher import ( +from smartsim._core.mli.comm.channel.dragon_fli import DragonFLIChannel +from smartsim._core.mli.infrastructure.control.device_manager import WorkerDevice +from smartsim._core.mli.infrastructure.control.request_dispatcher import ( RequestDispatcher, ) -from smartsim._core.mli.infrastructure.control.workermanager import ( +from smartsim._core.mli.infrastructure.control.worker_manager import ( WorkerManager, exception_handler, ) -from smartsim._core.mli.infrastructure.environmentloader import EnvironmentConfigLoader -from smartsim._core.mli.infrastructure.storage.dragonfeaturestore import ( +from smartsim._core.mli.infrastructure.environment_loader import EnvironmentConfigLoader +from smartsim._core.mli.infrastructure.storage.dragon_feature_store import ( DragonFeatureStore, ) -from smartsim._core.mli.infrastructure.storage.featurestore import ( +from smartsim._core.mli.infrastructure.storage.feature_store import ( FeatureStore, FeatureStoreKey, ) @@ -314,12 +314,12 @@ def mock_exception_handler(exc, reply_channel, failure_message): return exception_handler(exc, mock_reply_channel, failure_message) monkeypatch.setattr( - "smartsim._core.mli.infrastructure.control.workermanager.exception_handler", + "smartsim._core.mli.infrastructure.control.worker_manager.exception_handler", mock_exception_handler, ) monkeypatch.setattr( - "smartsim._core.mli.infrastructure.control.requestdispatcher.exception_handler", + "smartsim._core.mli.infrastructure.control.request_dispatcher.exception_handler", mock_exception_handler, ) diff --git a/tests/dragon/test_reply_building.py b/tests/dragon/test_reply_building.py index 5f179bbae0..7a8e637803 100644 --- a/tests/dragon/test_reply_building.py +++ b/tests/dragon/test_reply_building.py @@ -30,7 +30,7 @@ dragon = pytest.importorskip("dragon") -from smartsim._core.mli.infrastructure.control.workermanager import build_failure_reply +from smartsim._core.mli.infrastructure.control.worker_manager import build_failure_reply from smartsim._core.mli.infrastructure.worker.worker import InferenceReply if t.TYPE_CHECKING: diff --git a/tests/dragon/test_request_dispatcher.py b/tests/dragon/test_request_dispatcher.py index c8d97dd7ed..bcc1097871 100644 --- a/tests/dragon/test_request_dispatcher.py +++ b/tests/dragon/test_request_dispatcher.py @@ -61,19 +61,19 @@ from smartsim._core.entrypoints.service import Service from smartsim._core.mli.comm.channel.channel import CommChannelBase -from smartsim._core.mli.comm.channel.dragonchannel import DragonCommChannel -from smartsim._core.mli.comm.channel.dragonfli import DragonFLIChannel -from smartsim._core.mli.infrastructure.control.requestdispatcher import ( +from smartsim._core.mli.comm.channel.dragon_channel import DragonCommChannel +from smartsim._core.mli.comm.channel.dragon_fli import DragonFLIChannel +from smartsim._core.mli.infrastructure.control.request_dispatcher import ( RequestBatch, RequestDispatcher, ) -from smartsim._core.mli.infrastructure.control.workermanager import ( +from smartsim._core.mli.infrastructure.control.worker_manager import ( EnvironmentConfigLoader, ) -from smartsim._core.mli.infrastructure.storage.dragonfeaturestore import ( +from smartsim._core.mli.infrastructure.storage.dragon_feature_store import ( DragonFeatureStore, ) -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStore +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStore from smartsim._core.mli.infrastructure.worker.torch_worker import TorchWorker from smartsim._core.mli.message_handler import MessageHandler from smartsim.log import get_logger diff --git a/tests/dragon/test_torch_worker.py b/tests/dragon/test_torch_worker.py index 88e800240f..9a5ed6309f 100644 --- a/tests/dragon/test_torch_worker.py +++ b/tests/dragon/test_torch_worker.py @@ -37,7 +37,7 @@ from torch import nn from torch.nn import functional as F -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStoreKey +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStoreKey from smartsim._core.mli.infrastructure.worker.torch_worker import TorchWorker from smartsim._core.mli.infrastructure.worker.worker import ( ExecuteResult, diff --git a/tests/dragon/test_worker_manager.py b/tests/dragon/test_worker_manager.py index a334164257..ad41e571b8 100644 --- a/tests/dragon/test_worker_manager.py +++ b/tests/dragon/test_worker_manager.py @@ -49,15 +49,15 @@ from dragon.mpbridge.queues import DragonQueue from smartsim._core.mli.comm.channel.channel import CommChannelBase -from smartsim._core.mli.comm.channel.dragonfli import DragonFLIChannel -from smartsim._core.mli.infrastructure.control.workermanager import ( +from smartsim._core.mli.comm.channel.dragon_fli import DragonFLIChannel +from smartsim._core.mli.infrastructure.control.worker_manager import ( EnvironmentConfigLoader, WorkerManager, ) -from smartsim._core.mli.infrastructure.storage.dragonfeaturestore import ( +from smartsim._core.mli.infrastructure.storage.dragon_feature_store import ( DragonFeatureStore, ) -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStore +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStore from smartsim._core.mli.infrastructure.worker.torch_worker import TorchWorker from smartsim._core.mli.message_handler import MessageHandler from smartsim.log import get_logger diff --git a/tests/mli/featurestore.py b/tests/mli/featurestore.py index de748ae6e5..7ecc01814c 100644 --- a/tests/mli/featurestore.py +++ b/tests/mli/featurestore.py @@ -28,7 +28,7 @@ import typing as t import smartsim.error as sse -from smartsim._core.mli.infrastructure.storage.featurestore import FeatureStore +from smartsim._core.mli.infrastructure.storage.feature_store import FeatureStore from smartsim.log import get_logger logger = get_logger(__name__) From c825db49bbceaa59659d0006a7b8b636c573e624 Mon Sep 17 00:00:00 2001 From: AlyssaCote Date: Thu, 29 Aug 2024 18:53:11 -0500 Subject: [PATCH 2/4] missed test files --- smartsim/_core/mli/infrastructure/control/worker_manager.py | 2 +- smartsim/_core/mli/infrastructure/worker/worker.py | 2 +- tests/dragon/{featurestore.py => feature_store.py} | 0 tests/dragon/test_core_machine_learning_worker.py | 2 +- tests/dragon/test_request_dispatcher.py | 2 +- tests/dragon/test_worker_manager.py | 2 +- tests/mli/{featurestore.py => feature_store.py} | 0 7 files changed, 5 insertions(+), 5 deletions(-) rename tests/dragon/{featurestore.py => feature_store.py} (100%) rename tests/mli/{featurestore.py => feature_store.py} (100%) diff --git a/smartsim/_core/mli/infrastructure/control/worker_manager.py b/smartsim/_core/mli/infrastructure/control/worker_manager.py index 64e831f2a0..d831a879aa 100644 --- a/smartsim/_core/mli/infrastructure/control/worker_manager.py +++ b/smartsim/_core/mli/infrastructure/control/worker_manager.py @@ -43,6 +43,7 @@ from .....log import get_logger from ....entrypoints.service import Service from ....utils.timings import PerfTimer +from ...message_handler import MessageHandler from ..environment_loader import EnvironmentConfigLoader from ..worker.worker import ( InferenceReply, @@ -50,7 +51,6 @@ MachineLearningWorkerBase, RequestBatch, ) -from ...message_handler import MessageHandler from .device_manager import DeviceManager, WorkerDevice from .error_handling import build_failure_reply, exception_handler diff --git a/smartsim/_core/mli/infrastructure/worker/worker.py b/smartsim/_core/mli/infrastructure/worker/worker.py index 88c5732f9d..41de23b561 100644 --- a/smartsim/_core/mli/infrastructure/worker/worker.py +++ b/smartsim/_core/mli/infrastructure/worker/worker.py @@ -37,9 +37,9 @@ from .....error import SmartSimError from .....log import get_logger from ...comm.channel.channel import CommChannelBase -from ..storage.feature_store import FeatureStore, FeatureStoreKey from ...message_handler import MessageHandler from ...mli_schemas.model.model_capnp import Model +from ..storage.feature_store import FeatureStore, FeatureStoreKey if t.TYPE_CHECKING: from smartsim._core.mli.mli_schemas.response.response_capnp import Status diff --git a/tests/dragon/featurestore.py b/tests/dragon/feature_store.py similarity index 100% rename from tests/dragon/featurestore.py rename to tests/dragon/feature_store.py diff --git a/tests/dragon/test_core_machine_learning_worker.py b/tests/dragon/test_core_machine_learning_worker.py index 5c931186d7..ed9ac625cd 100644 --- a/tests/dragon/test_core_machine_learning_worker.py +++ b/tests/dragon/test_core_machine_learning_worker.py @@ -44,7 +44,7 @@ ) from smartsim._core.utils import installed_redisai_backends -from .featurestore import FileSystemFeatureStore, MemoryFeatureStore +from .feature_store import FileSystemFeatureStore, MemoryFeatureStore # The tests in this file belong to the dragon group pytestmark = pytest.mark.dragon diff --git a/tests/dragon/test_request_dispatcher.py b/tests/dragon/test_request_dispatcher.py index bcc1097871..eeb8cd238b 100644 --- a/tests/dragon/test_request_dispatcher.py +++ b/tests/dragon/test_request_dispatcher.py @@ -78,7 +78,7 @@ from smartsim._core.mli.message_handler import MessageHandler from smartsim.log import get_logger -from .featurestore import FileSystemFeatureStore +from .feature_store import FileSystemFeatureStore from .utils.channel import FileSystemCommChannel logger = get_logger(__name__) diff --git a/tests/dragon/test_worker_manager.py b/tests/dragon/test_worker_manager.py index ad41e571b8..1ebc512a50 100644 --- a/tests/dragon/test_worker_manager.py +++ b/tests/dragon/test_worker_manager.py @@ -62,7 +62,7 @@ from smartsim._core.mli.message_handler import MessageHandler from smartsim.log import get_logger -from .featurestore import FileSystemFeatureStore +from .feature_store import FileSystemFeatureStore from .utils.channel import FileSystemCommChannel logger = get_logger(__name__) diff --git a/tests/mli/featurestore.py b/tests/mli/feature_store.py similarity index 100% rename from tests/mli/featurestore.py rename to tests/mli/feature_store.py From 103642389874a3bfc04471de174ad36d5b3178df Mon Sep 17 00:00:00 2001 From: AlyssaCote Date: Thu, 29 Aug 2024 18:54:29 -0500 Subject: [PATCH 3/4] changelog --- doc/changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/changelog.md b/doc/changelog.md index bfe42c804c..004be997a0 100644 --- a/doc/changelog.md +++ b/doc/changelog.md @@ -13,6 +13,7 @@ Jump to: Description +- Filenames conform to snake case - Update SmartSim environment variables using new naming convention - Refactor `exception_handler` - Add RequestDispatcher and the possibility of batching inference requests From 2c746907f71394730925275271e2c4c8529e536d Mon Sep 17 00:00:00 2001 From: AlyssaCote Date: Fri, 30 Aug 2024 15:42:47 -0500 Subject: [PATCH 4/4] missed file --- ex/high_throughput_inference/mli_driver.py | 2 +- ...standalone_workermanager.py => standalone_worker_manager.py} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename ex/high_throughput_inference/{standalone_workermanager.py => standalone_worker_manager.py} (100%) diff --git a/ex/high_throughput_inference/mli_driver.py b/ex/high_throughput_inference/mli_driver.py index 807a70b219..36f427937c 100644 --- a/ex/high_throughput_inference/mli_driver.py +++ b/ex/high_throughput_inference/mli_driver.py @@ -13,7 +13,7 @@ NUM_RANKS = 4 NUM_WORKERS = 1 filedir = os.path.dirname(__file__) -worker_manager_script_name = os.path.join(filedir, "standalone_workermanager.py") +worker_manager_script_name = os.path.join(filedir, "standalone_worker_manager.py") app_script_name = os.path.join(filedir, "mock_app.py") model_name = os.path.join(filedir, f"resnet50.{DEVICE}.pt") diff --git a/ex/high_throughput_inference/standalone_workermanager.py b/ex/high_throughput_inference/standalone_worker_manager.py similarity index 100% rename from ex/high_throughput_inference/standalone_workermanager.py rename to ex/high_throughput_inference/standalone_worker_manager.py