Rename entry points #817
Merged
Rename entry points #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Right, this should not be remaned anymore because it is obsolete. Note in the migrating document is missing indeed. Could you create one for 0.14.0? Let's not bloc this PR with it such that we get the interface changes out for wasmvm and wasmd. |
webmaster128
approved these changes
Mar 3, 2021
Member
|
When you get the chance, could you rebase that on main to remove the cranelift CI jobs? |
maurolacy
force-pushed
the
rename-entry-points
branch
from
23f56a0 to
2d17593
Compare
Co-authored-by: Simon Warta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #807.
HandleMsg->ExecuteMsg.Note: Didn't rename
HandleResponse, because I understand it's being deprecated. I think we should mention that in the migration doc, i.e. to use the newResponsetype instead ofInitResponse/HandleResponse.