[refactor] Remove legacy manager UI support and tag from header

christian-byrne · christian-byrne · commit fe7278ff7d10 · 2025-09-19T01:30:28.000-07:00
Removes the legacy manager UI tag from the manager header along with all related functionality:

- Remove "Use Legacy UI" tag and tooltip from ManagerHeader component
- Remove legacy UI i18n translation keys from all language files
- Update ManagerUIState enum to only support DISABLED and NEW_UI states
- Remove isLegacyManagerUI function and related service endpoints
- Update openManager calls to remove legacy-specific options
- Remove legacy manager commands from core commands
- Update all tests to reflect the new two-state system
- When server doesn't support v4, manager is now disabled instead of falling back to legacy UI

This simplifies the manager architecture by removing the legacy UI fallback path entirely.
diff --git a/src/components/dialog/content/LoadWorkflowWarning.vue b/src/components/dialog/content/LoadWorkflowWarning.vue
@@ -119,8 +119,7 @@ const showInstallAllButton = computed(() => {
 
 const openManager = async () => {
   await managerState.openManager({
-    initialTab: ManagerTab.Missing,
-    showToastOnLegacyError: true
+    initialTab: ManagerTab.Missing
   })
 }
 
diff --git a/src/components/helpcenter/HelpCenterMenuContent.vue b/src/components/helpcenter/HelpCenterMenuContent.vue
@@ -315,8 +315,7 @@ const menuItems = computed<MenuItem[]>(() => {
       showRedDot: shouldShowManagerRedDot.value,
       action: async () => {
         await useManagerState().openManager({
-          initialTab: ManagerTab.All,
-          showToastOnLegacyError: false
+          initialTab: ManagerTab.All
         })
         emit('close')
       }
diff --git a/src/components/topbar/CommandMenubar.vue b/src/components/topbar/CommandMenubar.vue
@@ -139,8 +139,7 @@ const showSettings = (defaultPanel?: string) => {
 
 const showManageExtensions = async () => {
   await managerState.openManager({
-    initialTab: ManagerTab.All,
-    showToastOnLegacyError: false
+    initialTab: ManagerTab.All
   })
 }
 
diff --git a/src/composables/useCoreCommands.ts b/src/composables/useCoreCommands.ts
@@ -745,9 +745,7 @@ export function useCoreCommands(): ComfyCommand[] {
       label: 'Custom Nodes Manager',
       versionAdded: '1.12.10',
       function: async () => {
-        await useManagerState().openManager({
-          showToastOnLegacyError: true
-        })
+        await useManagerState().openManager()
       }
     },
     {
@@ -771,8 +769,7 @@ export function useCoreCommands(): ComfyCommand[] {
         }
 
         await managerState.openManager({
-          initialTab: ManagerTab.UpdateAvailable,
-          showToastOnLegacyError: false
+          initialTab: ManagerTab.UpdateAvailable
         })
       }
     },
@@ -783,8 +780,7 @@ export function useCoreCommands(): ComfyCommand[] {
       versionAdded: '1.17.0',
       function: async () => {
         await useManagerState().openManager({
-          initialTab: ManagerTab.Missing,
-          showToastOnLegacyError: false
+          initialTab: ManagerTab.Missing
         })
       }
     },
@@ -893,8 +889,7 @@ export function useCoreCommands(): ComfyCommand[] {
       label: 'Manager',
       function: async () => {
         await useManagerState().openManager({
-          initialTab: ManagerTab.All,
-          showToastOnLegacyError: false
+          initialTab: ManagerTab.All
         })
       }
     },
@@ -954,31 +949,6 @@ export function useCoreCommands(): ComfyCommand[] {
         modelSelectorDialog.show()
       }
     },
-    {
-      id: 'Comfy.Manager.CustomNodesManager.ShowLegacyCustomNodesMenu',
-      icon: 'pi pi-bars',
-      label: 'Custom Nodes (Legacy)',
-      versionAdded: '1.16.4',
-      function: async () => {
-        await useManagerState().openManager({
-          legacyCommand: 'Comfy.Manager.CustomNodesManager.ToggleVisibility',
-          showToastOnLegacyError: true,
-          isLegacyOnly: true
-        })
-      }
-    },
-    {
-      id: 'Comfy.Manager.ShowLegacyManagerMenu',
-      icon: 'mdi mdi-puzzle',
-      label: 'Manager Menu (Legacy)',
-      versionAdded: '1.16.4',
-      function: async () => {
-        await useManagerState().openManager({
-          showToastOnLegacyError: true,
-          isLegacyOnly: true
-        })
-      }
-    },
     {
       id: 'Comfy.Memory.UnloadModels',
       icon: 'mdi mdi-vacuum-outline',
diff --git a/src/locales/en/main.json b/src/locales/en/main.json
@@ -177,9 +177,7 @@
   },
   "manager": {
     "title": "Custom Nodes Manager",
-    "legacyMenuNotAvailable": "Legacy manager menu is not available, defaulting to the new manager menu.",
-    "legacyManagerUI": "Use Legacy UI",
-    "legacyManagerUIDescription": "To use the legacy Manager UI, start ComfyUI with --enable-manager-legacy-ui",
+    "managerNotAvailable": "Manager is not available. Please check your settings.",
     "failed": "Failed",
     "failedToInstall": "Failed to Install",
     "installError": "Install Error",
diff --git a/src/locales/es/main.json b/src/locales/es/main.json
@@ -633,9 +633,6 @@
     "installationQueue": "Cola de Instalación",
     "lastUpdated": "Última Actualización",
     "latestVersion": "Última",
-    "legacyManagerUI": "Usar UI antigua",
-    "legacyManagerUIDescription": "Para usar la UI antigua del Manager, inicia ComfyUI con --enable-manager-legacy-ui",
-    "legacyMenuNotAvailable": "El menú del administrador antiguo no está disponible en esta versión de ComfyUI. Por favor, utiliza el nuevo menú del administrador en su lugar.",
     "license": "Licencia",
     "loadingVersions": "Cargando versiones...",
     "nightlyVersion": "Nocturna",
diff --git a/src/locales/fr/main.json b/src/locales/fr/main.json
@@ -633,9 +633,6 @@
     "installationQueue": "File d'attente d'installation",
     "lastUpdated": "Dernière mise à jour",
     "latestVersion": "Dernière",
-    "legacyManagerUI": "Utiliser l'interface utilisateur héritée",
-    "legacyManagerUIDescription": "Pour utiliser l'interface utilisateur de gestion héritée, démarrez ComfyUI avec --enable-manager-legacy-ui",
-    "legacyMenuNotAvailable": "Le menu du gestionnaire de l'ancienne version n'est pas disponible dans cette version de ComfyUI. Veuillez utiliser le nouveau menu du gestionnaire à la place.",
     "license": "Licence",
     "loadingVersions": "Chargement des versions...",
     "nightlyVersion": "Nocturne",
diff --git a/src/locales/ja/main.json b/src/locales/ja/main.json
@@ -633,9 +633,6 @@
     "installationQueue": "インストールキュー",
     "lastUpdated": "最終更新日",
     "latestVersion": "最新",
-    "legacyManagerUI": "レガシーUIを使用する",
-    "legacyManagerUIDescription": "レガシーManager UIを使用するには、--enable-manager-legacy-uiを付けてComfyUIを起動してください",
-    "legacyMenuNotAvailable": "このバージョンのComfyUIでは、レガシーマネージャーメニューは利用できません。新しいマネージャーメニューを使用してください。",
     "license": "ライセンス",
     "loadingVersions": "バージョンを読み込んでいます...",
     "nightlyVersion": "ナイトリー",
diff --git a/src/locales/ko/main.json b/src/locales/ko/main.json
@@ -633,9 +633,6 @@
     "installationQueue": "설치 대기열",
     "lastUpdated": "마지막 업데이트",
     "latestVersion": "최신",
-    "legacyManagerUI": "구버전 매니저 UI 사용",
-    "legacyManagerUIDescription": "구버전 매니저 UI를 사용하려면, ComfyUI를 --enable-manager-legacy-ui로 시작하세요",
-    "legacyMenuNotAvailable": "이 버전의 ComfyUI에서는 구버전 매니저 메뉴를 사용할 수 없습니다. 대신 새로운 매니저 메뉴를 사용하십시오.",
     "license": "라이선스",
     "loadingVersions": "버전 로딩 중...",
     "nightlyVersion": "최신 테스트 버전(nightly)",
diff --git a/src/locales/ru/main.json b/src/locales/ru/main.json
@@ -633,9 +633,6 @@
     "installationQueue": "Очередь установки",
     "lastUpdated": "Последнее обновление",
     "latestVersion": "Последняя",
-    "legacyManagerUI": "Использовать устаревший UI",
-    "legacyManagerUIDescription": "Чтобы использовать устаревший UI менеджера, запустите ComfyUI с --enable-manager-legacy-ui",
-    "legacyMenuNotAvailable": "Устаревшее меню менеджера недоступно в этой версии ComfyUI. Пожалуйста, используйте новое меню менеджера.",
     "license": "Лицензия",
     "loadingVersions": "Загрузка версий...",
     "nightlyVersion": "Ночная",
diff --git a/src/locales/tr/main.json b/src/locales/tr/main.json
@@ -161,9 +161,6 @@
   },
   "manager": {
     "title": "Özel Düğüm Yöneticisi",
-    "legacyMenuNotAvailable": "Eski yönetici menüsü mevcut değil, yeni yönetici menüsüne varsayılan olarak geçiliyor.",
-    "legacyManagerUI": "Eski Arayüzü Kullan",
-    "legacyManagerUIDescription": "Eski Yönetici Arayüzünü kullanmak için ComfyUI'yi --enable-manager-legacy-ui ile başlatın",
     "failed": "Başarısız",
     "failedToInstall": "Yüklenemedi",
     "installError": "Yükleme Hatası",
diff --git a/src/locales/zh-TW/main.json b/src/locales/zh-TW/main.json
@@ -633,9 +633,6 @@
     "installationQueue": "安裝佇列",
     "lastUpdated": "最後更新",
     "latestVersion": "最新版本",
-    "legacyManagerUI": "使用舊版介面",
-    "legacyManagerUIDescription": "若要使用舊版管理介面，請以 --enable-manager-legacy-ui 啟動 ComfyUI",
-    "legacyMenuNotAvailable": "舊版管理選單不可用，已預設切換至新版管理選單。",
     "license": "授權條款",
     "loadingVersions": "正在載入版本...",
     "nightlyVersion": "每夜建置版",
diff --git a/src/workbench/extensions/manager/components/manager/ManagerHeader.test.ts b/src/workbench/extensions/manager/components/manager/ManagerHeader.test.ts
@@ -1,8 +1,6 @@
 import { mount } from '@vue/test-utils'
 import { createPinia } from 'pinia'
 import PrimeVue from 'primevue/config'
-import Tag from 'primevue/tag'
-import Tooltip from 'primevue/tooltip'
 import { describe, expect, it } from 'vitest'
 import { createI18n } from 'vue-i18n'
 
@@ -22,13 +20,7 @@ describe('ManagerHeader', () => {
   const createWrapper = () => {
     return mount(ManagerHeader, {
       global: {
-        plugins: [createPinia(), PrimeVue, i18n],
-        directives: {
-          tooltip: Tooltip
-        },
-        components: {
-          Tag
-        }
+        plugins: [createPinia(), PrimeVue, i18n]
       }
     })
   }
@@ -41,42 +33,13 @@ describe('ManagerHeader', () => {
     )
   })
 
-  it('displays the legacy manager UI tag', () => {
-    const wrapper = createWrapper()
-
-    const tag = wrapper.find('[data-pc-name="tag"]')
-    expect(tag.exists()).toBe(true)
-    expect(tag.text()).toContain(enMessages.manager.legacyManagerUI)
-  })
-
-  it('applies info severity to the tag', () => {
-    const wrapper = createWrapper()
-
-    const tag = wrapper.find('[data-pc-name="tag"]')
-    expect(tag.classes()).toContain('p-tag-info')
-  })
-
-  it('displays info icon in the tag', () => {
-    const wrapper = createWrapper()
-
-    const icon = wrapper.find('.pi-info-circle')
-    expect(icon.exists()).toBe(true)
-  })
-
-  it('has cursor-help class on the tag', () => {
-    const wrapper = createWrapper()
-
-    const tag = wrapper.find('[data-pc-name="tag"]')
-    expect(tag.classes()).toContain('cursor-help')
-  })
-
   it('has proper structure with flex container', () => {
     const wrapper = createWrapper()
 
-    const flexContainer = wrapper.find('.flex.justify-end.ml-auto.pr-4')
+    const flexContainer = wrapper.find('.flex.items-center')
     expect(flexContainer.exists()).toBe(true)
 
-    const tag = flexContainer.find('[data-pc-name="tag"]')
-    expect(tag.exists()).toBe(true)
+    const title = flexContainer.find('h2')
+    expect(title.exists()).toBe(true)
   })
 })
diff --git a/src/workbench/extensions/manager/components/manager/ManagerHeader.vue b/src/workbench/extensions/manager/components/manager/ManagerHeader.vue
@@ -4,22 +4,8 @@
       <h2 class="text-lg font-normal text-left">
         {{ $t('manager.discoverCommunityContent') }}
       </h2>
-      <div class="flex justify-end ml-auto pr-4 pl-2">
-        <Tag
-          v-tooltip.left="$t('manager.legacyManagerUIDescription')"
-          severity="info"
-          icon="pi pi-info-circle"
-          :value="$t('manager.legacyManagerUI')"
-          class="cursor-help ml-2"
-          :pt="{
-            root: { class: 'text-xs' }
-          }"
-        />
-      </div>
     </div>
   </div>
 </template>
 
-<script setup lang="ts">
-import Tag from 'primevue/tag'
-</script>
+<script setup lang="ts"></script>
diff --git a/src/workbench/extensions/manager/composables/useManagerState.ts b/src/workbench/extensions/manager/composables/useManagerState.ts
diff --git a/src/workbench/extensions/manager/services/comfyManagerService.ts b/src/workbench/extensions/manager/services/comfyManagerService.ts
diff --git a/tests-ui/tests/composables/useManagerState.test.ts b/tests-ui/tests/composables/useManagerState.test.ts
diff --git a/tests-ui/tests/store/comfyManagerStore.test.ts b/tests-ui/tests/store/comfyManagerStore.test.ts

Original file line number	Diff line number	Diff line change
`@@ -119,8 +119,7 @@ const showInstallAllButton = computed(() => {`
`119`	`119`
`120`	`120`	`const openManager = async () => {`
`121`	`121`	`await managerState.openManager({`
`122`		`- initialTab: ManagerTab.Missing,`
`123`		`- showToastOnLegacyError: true`
	`122`	`+ initialTab: ManagerTab.Missing`
`124`	`123`	`})`
`125`	`124`	`}`
`126`	`125`
Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,7 @@ const showSettings = (defaultPanel?: string) => {`
`139`	`139`
`140`	`140`	`const showManageExtensions = async () => {`
`141`	`141`	`await managerState.openManager({`
`142`		`- initialTab: ManagerTab.All,`
`143`		`- showToastOnLegacyError: false`
	`142`	`+ initialTab: ManagerTab.All`
`144`	`143`	`})`
`145`	`144`	`}`
`146`	`145`