Return null on key not found

Jacob Christiansen · Jacob Christiansen · commit e00b99dc8d50 · 2015-03-27T13:30:02.000+01:00
diff --git a/lib/Store/Redis.php b/lib/Store/Redis.php
@@ -37,6 +37,10 @@ public function get($type, $key)
         $redisKey = "{$this->prefix}.$type.$key";
         $value = $this->redis->get($redisKey);
 
+        if (is_null($value)) {
+            return null;
+        }
+
         return unserialize($value);
     }
 
diff --git a/test/Store/RedisTest.php b/test/Store/RedisTest.php
@@ -126,7 +126,7 @@ public function testGetNonExistingKey()
             $res = $store->get('test', 'nokey');
 
             $this->assertEquals('simpleSAMLphp.test.nokey', Predis\Client::$getKey);
-            $this->assertFalse($res);
+            $this->assertNull($res);
         }
 
         public function testDeleteKey()

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,10 @@ public function get($type, $key)`
`37`	`37`	`$redisKey = "{$this->prefix}.$type.$key";`
`38`	`38`	`$value = $this->redis->get($redisKey);`
`39`	`39`
	`40`	`+ if (is_null($value)) {`
	`41`	`+ return null;`
	`42`	`+ }`
	`43`	`+`
`40`	`44`	`return unserialize($value);`
`41`	`45`	`}`
`42`	`46`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ public function testGetNonExistingKey()`
`126`	`126`	`$res = $store->get('test', 'nokey');`
`127`	`127`
`128`	`128`	`$this->assertEquals('simpleSAMLphp.test.nokey', Predis\Client::$getKey);`
`129`		`- $this->assertFalse($res);`
	`129`	`+ $this->assertNull($res);`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`public function testDeleteKey()`