chore(cs): use stricter rule set

Author: SamMousa

ecs.php

@@ -27,7 +27,7 @@
     ]);
 
     // A. full sets
-    $ecsConfig->sets([SetList::PSR_12, SetList::SPACES]);
+    $ecsConfig->sets([SetList::PSR_12, SetList::SPACES, SetList::STRICT]);
 
     $ecsConfig->rule(NotOperatorWithSuccessorSpaceFixer::class);
     $ecsConfig->rule(ArraySyntaxFixer::class);
@@ -40,11 +40,10 @@
     ]);
     $ecsConfig->rule(NoEmptyPhpdocFixer::class);
     $ecsConfig->rule(NoUnusedImportsFixer::class);
-    $ecsConfig->rule(DeclareStrictTypesFixer::class);
     $ecsConfig->ruleWithConfiguration(FinalInternalClassFixer::class, [
         'annotation_exclude' => ['@not-fix', '@internal'],
         'annotation_include' => [],
-        'consider_absent_docblock_as_internal_class' => \true
+        'consider_absent_docblock_as_internal_class' => true
     ]);
     $ecsConfig->ruleWithConfiguration(ForbiddenFunctionsSniff::class, [
         'forbiddenFunctions' => [

src/Codeception/Lib/Connector/Yii2.php

@@ -17,21 +17,20 @@
 use Symfony\Component\BrowserKit\Request as BrowserkitRequest;
 use Symfony\Component\BrowserKit\Response;
 use Yii;
-use yii\base\Component;
 use yii\base\Event;
 use yii\base\ExitException;
 use yii\base\Security;
 use yii\base\UserException;
 use yii\mail\BaseMessage;
 use yii\web\Application;
 use yii\web\IdentityInterface;
-use yii\web\Request;
 use yii\web\Request as YiiRequest;
 use yii\web\Response as YiiResponse;
 use yii\web\User;
 
 /**
  * @extends Client<BrowserkitRequest, Response>
+ * @internal This class is not part of the public API
  */
 final class Yii2 extends Client
 {

tests/cases/sqlite/fixtures/TestFixture.php

@@ -31,7 +31,7 @@ public function unload()
         foreach ($this->dbComponents as $name) {
             /** @var Connection $connection */
             $connection = \Yii::$app->get($name);
-            if (in_array($this->tableName, $connection->getSchema()->getTableNames('', true))) {
+            if (in_array($this->tableName, $connection->getSchema()->getTableNames('', true), true)) {
                 $connection->createCommand()->dropTable($this->tableName)->execute();
             }
         }