Include workaround for TypeScript compiler bug

The TypeScript compiler has a bug where, when you implement an
interface in JSDoc which is defined in a `.d.ts` file which
uses a namespace, it generates an invalid declaration file [1].

To workaround this bug, we have to add global interfaces that
are essentially aliases of the actual interfaces. As a result,
the TypeScript compiler no longer fails with resolving.

Update Closure accordingly such that we can use the correct
type to work in both Closure and TypeScript.

[1]: microsoft/TypeScript#38640

[email protected],[email protected]
[email protected],[email protected]

Bug: 1081686, 1011811
Change-Id: I088a4520c90ce0873cf9850a8ed65f9c8dd896ef
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2208978
Reviewed-by: Paul Lewis <[email protected]>
Commit-Queue: Tim van der Lippe <[email protected]>

Author: TimvdLippe

front_end/generated/protocol-proxy-api.d.ts

@@ -3629,3 +3629,51 @@ declare namespace ProtocolProxyApi {
   }
   export interface SchemaDispatcher extends Protocol.Dispatcher {}
 }
+
+// Include the workaround for https://github.com/microsoft/TypeScript/issues/38640
+interface ProtocolProxyApiWorkaround_AccessibilityDispatcher extends ProtocolProxyApi.AccessibilityDispatcher {}
+interface ProtocolProxyApiWorkaround_AnimationDispatcher extends ProtocolProxyApi.AnimationDispatcher {}
+interface ProtocolProxyApiWorkaround_ApplicationCacheDispatcher extends ProtocolProxyApi.ApplicationCacheDispatcher {}
+interface ProtocolProxyApiWorkaround_AuditsDispatcher extends ProtocolProxyApi.AuditsDispatcher {}
+interface ProtocolProxyApiWorkaround_BackgroundServiceDispatcher extends ProtocolProxyApi.BackgroundServiceDispatcher {}
+interface ProtocolProxyApiWorkaround_BrowserDispatcher extends ProtocolProxyApi.BrowserDispatcher {}
+interface ProtocolProxyApiWorkaround_CSSDispatcher extends ProtocolProxyApi.CSSDispatcher {}
+interface ProtocolProxyApiWorkaround_CacheStorageDispatcher extends ProtocolProxyApi.CacheStorageDispatcher {}
+interface ProtocolProxyApiWorkaround_CastDispatcher extends ProtocolProxyApi.CastDispatcher {}
+interface ProtocolProxyApiWorkaround_DOMDispatcher extends ProtocolProxyApi.DOMDispatcher {}
+interface ProtocolProxyApiWorkaround_DOMDebuggerDispatcher extends ProtocolProxyApi.DOMDebuggerDispatcher {}
+interface ProtocolProxyApiWorkaround_DOMSnapshotDispatcher extends ProtocolProxyApi.DOMSnapshotDispatcher {}
+interface ProtocolProxyApiWorkaround_DOMStorageDispatcher extends ProtocolProxyApi.DOMStorageDispatcher {}
+interface ProtocolProxyApiWorkaround_DatabaseDispatcher extends ProtocolProxyApi.DatabaseDispatcher {}
+interface ProtocolProxyApiWorkaround_DeviceOrientationDispatcher extends ProtocolProxyApi.DeviceOrientationDispatcher {}
+interface ProtocolProxyApiWorkaround_EmulationDispatcher extends ProtocolProxyApi.EmulationDispatcher {}
+interface ProtocolProxyApiWorkaround_HeadlessExperimentalDispatcher extends
+    ProtocolProxyApi.HeadlessExperimentalDispatcher {}
+interface ProtocolProxyApiWorkaround_IODispatcher extends ProtocolProxyApi.IODispatcher {}
+interface ProtocolProxyApiWorkaround_IndexedDBDispatcher extends ProtocolProxyApi.IndexedDBDispatcher {}
+interface ProtocolProxyApiWorkaround_InputDispatcher extends ProtocolProxyApi.InputDispatcher {}
+interface ProtocolProxyApiWorkaround_InspectorDispatcher extends ProtocolProxyApi.InspectorDispatcher {}
+interface ProtocolProxyApiWorkaround_LayerTreeDispatcher extends ProtocolProxyApi.LayerTreeDispatcher {}
+interface ProtocolProxyApiWorkaround_LogDispatcher extends ProtocolProxyApi.LogDispatcher {}
+interface ProtocolProxyApiWorkaround_MemoryDispatcher extends ProtocolProxyApi.MemoryDispatcher {}
+interface ProtocolProxyApiWorkaround_NetworkDispatcher extends ProtocolProxyApi.NetworkDispatcher {}
+interface ProtocolProxyApiWorkaround_OverlayDispatcher extends ProtocolProxyApi.OverlayDispatcher {}
+interface ProtocolProxyApiWorkaround_PageDispatcher extends ProtocolProxyApi.PageDispatcher {}
+interface ProtocolProxyApiWorkaround_PerformanceDispatcher extends ProtocolProxyApi.PerformanceDispatcher {}
+interface ProtocolProxyApiWorkaround_SecurityDispatcher extends ProtocolProxyApi.SecurityDispatcher {}
+interface ProtocolProxyApiWorkaround_ServiceWorkerDispatcher extends ProtocolProxyApi.ServiceWorkerDispatcher {}
+interface ProtocolProxyApiWorkaround_StorageDispatcher extends ProtocolProxyApi.StorageDispatcher {}
+interface ProtocolProxyApiWorkaround_SystemInfoDispatcher extends ProtocolProxyApi.SystemInfoDispatcher {}
+interface ProtocolProxyApiWorkaround_TargetDispatcher extends ProtocolProxyApi.TargetDispatcher {}
+interface ProtocolProxyApiWorkaround_TetheringDispatcher extends ProtocolProxyApi.TetheringDispatcher {}
+interface ProtocolProxyApiWorkaround_TracingDispatcher extends ProtocolProxyApi.TracingDispatcher {}
+interface ProtocolProxyApiWorkaround_FetchDispatcher extends ProtocolProxyApi.FetchDispatcher {}
+interface ProtocolProxyApiWorkaround_WebAudioDispatcher extends ProtocolProxyApi.WebAudioDispatcher {}
+interface ProtocolProxyApiWorkaround_WebAuthnDispatcher extends ProtocolProxyApi.WebAuthnDispatcher {}
+interface ProtocolProxyApiWorkaround_MediaDispatcher extends ProtocolProxyApi.MediaDispatcher {}
+interface ProtocolProxyApiWorkaround_ConsoleDispatcher extends ProtocolProxyApi.ConsoleDispatcher {}
+interface ProtocolProxyApiWorkaround_DebuggerDispatcher extends ProtocolProxyApi.DebuggerDispatcher {}
+interface ProtocolProxyApiWorkaround_HeapProfilerDispatcher extends ProtocolProxyApi.HeapProfilerDispatcher {}
+interface ProtocolProxyApiWorkaround_ProfilerDispatcher extends ProtocolProxyApi.ProfilerDispatcher {}
+interface ProtocolProxyApiWorkaround_RuntimeDispatcher extends ProtocolProxyApi.RuntimeDispatcher {}
+interface ProtocolProxyApiWorkaround_SchemaDispatcher extends ProtocolProxyApi.SchemaDispatcher {}

scripts/build/generate_protocol_externs.py

@@ -280,6 +280,10 @@ def generate_protocol_externs(output_path, file1, file2):
         output_file.write("/** @interface */\n")
         output_file.write("ProtocolProxyApi.%sDispatcher = function() {};\n" %
                           domain_name)
+        # Include the workaround for https://github.com/microsoft/TypeScript/issues/38640
+        output_file.write(
+            "var ProtocolProxyApiWorkaround_%sDispatcher = ProtocolProxyApi.%sDispatcher;\n"
+            % (domain_name, domain_name))
         if "events" in domain:
             for event in domain["events"]:
                 params = []

scripts/protocol_typescript/protocol_dts_generator.ts

@@ -402,6 +402,12 @@ const emitApi = (moduleName: string, protocolModuleName: string, domains: Protoc
   domains.forEach(d => emitDomainApi(d, protocolModulePrefix));
   emitCloseBlock();
   emitLine();
+
+  emitLine('// Include the workaround for https://github.com/microsoft/TypeScript/issues/38640');
+  domains.forEach(d => {
+    emitLine(
+        `interface ProtocolProxyApiWorkaround_${d.domain}Dispatcher extends ProtocolProxyApi.${d.domain}Dispatcher {}`);
+  });
 };
 
 const flushEmitToFile = (path: string) => {