Skip to content

Don't rely on implicit binding creation of setglobal! #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmaccode merged 1 commit into from
Jun 6, 2024
Merged

Don't rely on implicit binding creation of setglobal! #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/core.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,6 +1143,19 @@ function start! end

function start!(mod::Module = Main, ip::IP4 = ip4_cli(Main.ARGS);
threads::Int64 = 1, router_threads::UnitRange{Int64} = -2:threads)

# Inject bindings we will use into the module
if !isdefined(mod, :server)
Core.eval(mod, :(global server, data, routes))

# Switch to the latest world where the bindings are available
invokelatest(_start!, mod, ip, threads, router_threads)
else
_start!(mod, ip, threads, router_threads)
end
end

function _start!(mod::Module, ip::IP4, threads::Int64, router_threads::UnitRange{Int64})
IP = Sockets.InetAddr(parse(IPAddr, ip.ip), ip.port)
server::Sockets.TCPServer = Sockets.listen(IP)
mod.server = server
Expand Down Expand Up @@ -1210,6 +1223,7 @@ function generate_router(mod::Module, ip::IP4)
mod.routes = Vector{AbstractRoute}()
loaded = []
for name in server_ns
isdefined(mod, name) || continue
f = getfield(mod, name)
T = typeof(f)
if T <: AbstractExtension
Expand Down