Skip to content

fix: runsFactor in benchmark #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: runsFactor in benchmark #467

merged 1 commit into from
Oct 31, 2023

Conversation

@twoeths
Copy link
Contributor

@twoeths twoeths commented Oct 27, 2023

Description

Fix runsFactor in protobuf benchmark. The result on Mac M1:

protobuf
    ✔ decode Attestation message using protobufjs                          3310020 ops/s    302.1130 ns/op   x1.003     395672 runs    120 s
    ✔ encode Attestation message using protobufjs                          2419082 ops/s    413.3800 ns/op   x1.040     288753 runs    120 s

@twoeths twoeths requested a review from a team as a code owner October 27, 2023 07:39
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@twoeths twoeths merged commit aa208c2 into master Oct 31, 2023
@twoeths twoeths deleted the tuyen/update_benchmark branch October 31, 2023 04:34
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dapplion dapplion dapplion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@twoeths @codecov-commenter @dapplion