Skip to content

an obvious error in the documentation comments in OrthographicFrustum.js. #12537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jianbingZhou opened this issue Mar 26, 2025 · 1 comment

Comments

@jianbingZhou
Copy link

What happened?

I found an obvious error in the documentation comments in OrthographicFrustum.js.

The documentation for ​offCenterFrustum is directly copied from ​projectionMatrix's description? This is clearly wrong.

Object.defineProperties(OrthographicFrustum.prototype, {
  /**
   * Gets the orthographic projection matrix computed from the view frustum.
   * @memberof OrthographicFrustum.prototype
   * @type {Matrix4}
   * @readonly
   */
  projectionMatrix: {
    get: function () {
      update(this);
      return this._offCenterFrustum.projectionMatrix;
    },
  },
  /**
   * Gets the orthographic projection matrix computed from the view frustum.
   * @memberof OrthographicFrustum.prototype
   * @type {OrthographicOffCenterFrustum}
   * @readonly
   * @private
   */
  offCenterFrustum: {
    get: function () {
      update(this);
      return this._offCenterFrustum;
    },
  },
});

Reproduction steps

No response

Sandcastle example

No response

Environment

Browser:
CesiumJS Version:
Operating System:

@ggetz ggetz added category - doc good first issue An opportunity for first time contributors and removed needs triage labels Apr 7, 2025
@ggetz
Copy link
Contributor

ggetz commented Apr 7, 2025

@ggetz ggetz added category - architecture / api and removed good first issue An opportunity for first time contributors labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants