Merge pull request #12 from Casecommons/4.8.0.signature-fix

Katy Feng · web-flow · commit 1a41e06c5f54 · 2021-04-02T17:15:13.000-04:00
diff --git a/src/components/signature/Signature.js b/src/components/signature/Signature.js
@@ -67,7 +67,7 @@ export default class SignatureComponent extends Input {
 
   setValue(value, flags = {}) {
     const changed = super.setValue(value, flags);
-    if (value && this.refs.signatureImage && (!flags.noSign || this.options.readOnly)) {
+    if (value && this.refs.signatureImage && this.options.readOnly) {
       this.refs.signatureImage.setAttribute('src', value);
       this.showCanvas(false);
     }
@@ -142,7 +142,7 @@ export default class SignatureComponent extends Input {
       this.signaturePad.clear();
 
       if (this.dataValue) {
-        this.setDataToSigaturePad();
+        this.signaturePad.fromDataURL(this.dataValue);
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ export default class SignatureComponent extends Input {`
`67`	`67`
`68`	`68`	`setValue(value, flags = {}) {`
`69`	`69`	`const changed = super.setValue(value, flags);`
`70`		`- if (value && this.refs.signatureImage && (!flags.noSign \|\| this.options.readOnly)) {`
	`70`	`+ if (value && this.refs.signatureImage && this.options.readOnly) {`
`71`	`71`	`this.refs.signatureImage.setAttribute('src', value);`
`72`	`72`	`this.showCanvas(false);`
`73`	`73`	`}`
`@@ -142,7 +142,7 @@ export default class SignatureComponent extends Input {`
`142`	`142`	`this.signaturePad.clear();`
`143`	`143`
`144`	`144`	`if (this.dataValue) {`
`145`		`- this.setDataToSigaturePad();`
	`145`	`+ this.signaturePad.fromDataURL(this.dataValue);`
`146`	`146`	`}`
`147`	`147`	`}`
`148`	`148`	`}`