refactor

prepare for making version-deletions clearer

Author: Byron

Cargo.toml

@@ -46,6 +46,7 @@ ahash = "0.8.0"
 hashbrown = { version = "0.14.0", features = ["raw"] }
 
 [dev-dependencies]
+gix = { version = "0.48.0", default-features = false, features = ["regex"] }
 gix-testtools = "0.12.0"
 crates-index = "0.19.10"
 tempdir = "0.3.5"

tests/fixtures/generated-archives/make-index-from-parts.tar.xz

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:efca9de35ae159baebe515c0493d779a4847cdad81f6c10bfe10ba29f489cf51
-size 622600
+oid sha256:0fb4eff8580681c0ba6251b18ec7b78503881bd38b185b0209745d24b7fffedd
+size 593240

tests/index/changes_between_commits.rs

@@ -85,16 +85,35 @@ fn addition() -> crate::Result {
 }
 
 #[test]
-fn deletion() -> crate::Result {
+fn crate_deletion_with_single_version() -> crate::Result {
     let changes = changes(index_ro()?, "@^{/Delete crates}")?;
     assert_eq!(changes.len(), 1);
+    let (name, versions) = changes
+        .first()
+        .and_then(|c| c.crate_deleted())
+        .expect("CrateDeleted event");
+    assert_eq!(name, "girl");
     assert_eq!(
-        changes.first().and_then(|c| c.crate_deleted().map(|t| t.0)),
-        Some("girl")
+        versions.len(),
+        1,
+        "there was only one version, it's still detected as crate deletion though"
     );
     Ok(())
 }
 
+#[test]
+fn crate_deletion_with_multiple_versions() -> crate::Result {
+    let changes = changes(index_ro()?, "@^{/Delete crate\n}")?;
+    assert_eq!(changes.len(), 1);
+    let (name, versions) = changes
+        .first()
+        .and_then(|c| c.crate_deleted())
+        .expect("CrateDeleted event");
+    assert_eq!(name, "git-fuse");
+    assert_eq!(versions.len(), 4, "there were 4 versions in the file");
+    Ok(())
+}
+
 #[test]
 fn new_version() -> crate::Result {
     let changes = changes(index_ro()?, ":/Updating crate `git-repository#0.22.1`")?;