Expose access token cache count #5330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...Microsoft.Identity.Client/PlatformsCommon/Shared/InMemoryPartitionedAppTokenCacheAccessor.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Identity.Client/PlatformsCommon/Shared/InMemoryPartitionedAppTokenCacheAccessor.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Identity.Client/PlatformsCommon/Shared/InMemoryPartitionedAppTokenCacheAccessor.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Identity.Client/PlatformsCommon/Shared/InMemoryPartitionedUserTokenCacheAccessor.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Identity.Client/PlatformsCommon/Shared/InMemoryPartitionedUserTokenCacheAccessor.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Performance/AcquireTokenForClientCacheTests.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Is this new telemetry always enabled? And there's no way to disable it? Is that correct? |
...Microsoft.Identity.Client/PlatformsCommon/Shared/InMemoryPartitionedAppTokenCacheAccessor.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
neha-bhargava
approved these changes
Jun 10, 2025
bgavrilMS
force-pushed
the
bogdanrobbie/cache
branch
2 times, most recently
from
8769561 to
b295e3b
Compare
Robbie-Microsoft
approved these changes
Jun 11, 2025
bgavrilMS
force-pushed
the
bogdanrobbie/cache
branch
3 times, most recently
from
e27afa6 to
63b1f87
Compare
Robbie-Microsoft
approved these changes
Jun 16, 2025
bgavrilMS
force-pushed
the
bogdanrobbie/cache
branch
from
55ddbd6 to
634e4a5
Compare
Robbie-Microsoft
approved these changes
Jun 16, 2025
This was referenced Jul 25, 2025
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 24, 2025
Closed
Closed
This was referenced Nov 3, 2025
This was referenced Nov 10, 2025
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5329
Changes proposed in this request
Expose the cached access token count.
Testing
Unit
Performance impact
By keeping a count variable, we do not enumerate dictionaries, so this op is O(1)
Documentation