Add mac broker console app support #5274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengga
force-pushed
the
fengga/mac-broker-console-app-support
branch
from
0a2161a to
2f1f0fd
Compare
…l into NativeInterop interactive API
fengga
force-pushed
the
fengga/mac-broker-console-app-support
branch
from
2f1f0fd to
242fd39
Compare
bgavrilMS
reviewed
Jun 2, 2025
src/client/Microsoft.Identity.Client/Utils/MacMainThreadScheduler.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jun 2, 2025
iulico-1
reviewed
Jun 2, 2025
src/client/Microsoft.Identity.Client/Utils/MacMainThreadScheduler.cs
Outdated
Show resolved
Hide resolved
iulico-1
reviewed
Jun 2, 2025
…ler.cs Co-authored-by: Bogdan Gavril <[email protected]>
bgavrilMS
approved these changes
Jun 3, 2025
This was referenced Jul 25, 2025
This was referenced Aug 5, 2025
This was referenced Aug 18, 2025
Closed
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 24, 2025
Closed
Closed
This was referenced Nov 3, 2025
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeInterop 0.19.0 from nuget already contains mac console app support code.
This PR enables console app support from MSAL.dotnet side, and add a sample app.
Internally, this PR removed authority validation if it is a broker flow on macOS. Brokers have their own authority validation processes, and making http requests will switch to a background thread, which will break the main thread context for broker interactive flows.
Changes proposed in this request
Testing
Performance impact
Documentation