Skip to content

Add new version 2018-04-02 for Microsoft.StorageSync Resource Provider #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add new version 2018-04-02 for Microsoft.StorageSync Resource Provider #3229

wants to merge 1 commit into from

Conversation

@ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Jun 13, 2018 •
edited
Loading

Add new version 2018-04-02 for Microsoft.StorageSync Resource Provider

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@ankushbindlish2
Add new version 2018-04-02 for Microsoft.StorageSync Resource Provider
4235a19 
Add new version 2018-04-02 for Microsoft.StorageSync Resource Provider
@azuresdkci azuresdkci requested a review from jianghaolu June 13, 2018 19:35
@AutorestCI AutorestCI mentioned this pull request Jun 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 13, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2734

@AutorestCI
Copy link

AutorestCI commented Jun 13, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 13, 2018 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2985

@AutorestCI AutorestCI mentioned this pull request Jun 13, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 13, 2018 •
edited
Loading

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#252

@ankushbindlish2
Copy link
Member Author

ankushbindlish2 commented Jun 13, 2018

Preview Version : #3211

@AutorestCI
Copy link

AutorestCI commented Jun 13, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

jianghaolu
jianghaolu reviewed Jun 13, 2018
View reviewed changes
...ource-manager/Microsoft.StorageSync/stable/2018-04-02/examples/RegisteredServers_Create.json
"discoveryEndpointUri": "\"https://kailanitest99.one.microsoft.com:443\"",
"resourceLocation": "westus",
"serviceLocation": "westus"
},
Copy link
Contributor

@jianghaolu jianghaolu Jun 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid JSON - remove extra comma

@jianghaolu
Copy link
Contributor

jianghaolu commented Jun 13, 2018

@annatisch Seems like you reviewed the preview version - do you plan to review this one?

anuchandy
anuchandy requested changes Jun 13, 2018
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushbindlish2 could you please follow the instructions I mentioned in the email i.e. splitting this PR into two commits, review will be fast when we can see the diff.

@ankushbindlish2
Copy link
Member Author

ankushbindlish2 commented Jun 14, 2018

@anuchandy : Did you mean like this ? #3238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy requested changes

+1 more reviewer

@jianghaolu jianghaolu jianghaolu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jianghaolu jianghaolu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ankushbindlish2 @AutorestCI @jianghaolu @anuchandy