Enable TenantId to Retrieve Auxiliary Auth Header #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msJinLei
force-pushed
the
auxHeaderTenant2
branch
2 times, most recently
from
41a8d58 to
41ec3d9
Compare
msJinLei
force-pushed
the
auxHeaderTenant2
branch
from
41ec3d9 to
2220581
Compare
isra-fel
requested changes
Jan 18, 2024
wyunchi-ms
reviewed
Jan 18, 2024
Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>
msJinLei
force-pushed
the
auxHeaderTenant2
branch
from
f857496 to
5383e04
Compare
isra-fel
previously approved these changes
Jan 22, 2024
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Please provide context in PR descrption. You can leverage the AIG draft BTW
wyunchi-ms
previously approved these changes
Jan 22, 2024
wyunchi-ms
approved these changes
Jan 22, 2024
isra-fel
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to add new unit tests and methods related to authentication functionality. The most important changes include adding a new unit test class
AzureRMCmdletAuthenticationUnitTestswith test methods for theGetAuxilaryAuthHeaderByTenatIdsmethod, and adding a new methodGetAuxiliaryAuthHeaderFromTenantIdsto theAzureRMCmdletclass for generating authentication headers.Authentication improvements:
src/ResourceManager/Version2016_09_01/AzureRMCmdlet.cs: Added a new methodGetAuxiliaryAuthHeaderFromTenantIdsto theAzureRMCmdletclass for generating authentication headers for a list of tenant IDs.Testing improvements:
src/ResourceManager.Test/AzureRMCmdletAuthenticationUnitTests.cs: Added a new unit test classAzureRMCmdletAuthenticationUnitTestswith test methods to test the functionality of theGetAuxilaryAuthHeaderByTenatIdsmethod.