Update Python worker imports to use proper paths #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
reviewed
Aug 27, 2019
| import "identity/ClaimsIdentityRpc.proto"; | ||
| import "shared/NullableTypes.proto"; | ||
| import "azure_functions_worker/protos/ClaimsIdentityRpc.proto"; | ||
| import "azure_functions_worker/protos/NullableTypes.proto"; |
Member
There was a problem hiding this comment.
removed shared? intentional? needed to flatten dir structure?
Contributor
Author
There was a problem hiding this comment.
Yes, that's intentional. I copy the files over into a staging folder where they are flattened and then I run the compiler. With these import statements, the compiler is able to figure out the proper absolute imports without me having to do any fancy regex manipulation. I pulled in the protobuf changes into my private repo so I could get a CI run if you wanted to see the full context: maiqbal11/azure-functions-python-worker#24.
pragnagopa
approved these changes
Aug 27, 2019
yojagad
added a commit
to yojagad/azure-functions-language-worker-protobuf
that referenced
this pull request
Sep 19, 2019
This reverts commit e13f4a2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.