Skip to content

style(buffer): change ".split" to "utils.each" for defining methods #12160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Uzlopak merged 1 commit into from
Jul 27, 2022
Merged

style(buffer): change ".split" to "utils.each" for defining methods #12160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions lib/types/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,25 +142,26 @@ MongooseBuffer.mixin = {
* Compile other Buffer methods marking this buffer as modified.
*/

(
// node < 0.5
('writeUInt8 writeUInt16 writeUInt32 writeInt8 writeInt16 writeInt32 ' +
'writeFloat writeDouble fill ' +
'utf8Write binaryWrite asciiWrite set ' +

// node >= 0.5
'writeUInt16LE writeUInt16BE writeUInt32LE writeUInt32BE ' +
'writeInt16LE writeInt16BE writeInt32LE writeInt32BE ' + 'writeFloatLE writeFloatBE writeDoubleLE writeDoubleBE')
).split(' ').forEach(function(method) {
if (!Buffer.prototype[method]) {
return;
}
MongooseBuffer.mixin[method] = function() {
const ret = Buffer.prototype[method].apply(this, arguments);
this._markModified();
return ret;
};
});
utils.each(
[
// node < 0.5
'writeUInt8', 'writeUInt16', 'writeUInt32', 'writeInt8', 'writeInt16', 'writeInt32',
'writeFloat', 'writeDouble', 'fill',
'utf8Write', 'binaryWrite', 'asciiWrite', 'set',

// node >= 0.5
'writeUInt16LE', 'writeUInt16BE', 'writeUInt32LE', 'writeUInt32BE',
'writeInt16LE', 'writeInt16BE', 'writeInt32LE', 'writeInt32BE', 'writeFloatLE', 'writeFloatBE', 'writeDoubleLE', 'writeDoubleBE']
, function(method) {
if (!Buffer.prototype[method]) {
return;
}
MongooseBuffer.mixin[method] = function() {
const ret = Buffer.prototype[method].apply(this, arguments);
this._markModified();
return ret;
};
});

/**
* Converts this buffer to its Binary type representation.
Expand Down