Compatibility with ES modules #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been authoring some of the new code in ES modules now that nodejs supports those natively. However turns out there is no good story around testing ES modules without transpiling them first.
To overcome this I have forked this library turning it into ES modules and using combination of rollup + export maps to make it usable from commonjs modules as well. In addition I have also:
messageargument toexpectwhich I discovered many of the existing tests written for chai used.Please let me know if you have any interest in taking these changes, otherwise I'll publish my fork under the different name so I could use it across multiple libraries I'm working on.