-
-
Notifications
You must be signed in to change notification settings - Fork 304
refactor(typescript)!: remove eslint and prettier #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
|
This didnt work, so I am removing the dap configuration for now. {
"mfussenegger/nvim-dap",
optional = true,
opts = function()
local dap = require "dap"
if not dap.adapters["pwa-node"] then
dap.adapters["pwa-node"] = {
type = "server",
host = "localhost",
port = "${port}",
executable = { command = vim.fn.exepath "js-debug-adapter", args = { "${port}" } },
}
end
if not dap.adapters.node then
dap.adapters.node = function(cb, config)
if config.type == "node" then config.type = "pwa-node" end
local pwa_adapter = dap.adapters["pwa-node"]
if type(pwa_adapter) == "function" then
pwa_adapter(cb, config)
else
cb(pwa_adapter)
end
end
end
local js_filetypes = { "typescript", "javascript", "typescriptreact", "javascriptreact" }
local js_config = {
{
type = "pwa-node",
request = "launch",
name = "Launch file",
program = "${file}",
cwd = "${workspaceFolder}",
},
{
type = "pwa-node",
request = "attach",
name = "Attach",
processId = require("dap.utils").pick_process,
cwd = "${workspaceFolder}",
},
}
for _, language in ipairs(js_filetypes) do
if not dap.configurations[language] then dap.configurations[language] = js_config end
end
local vscode_filetypes = require("dap.ext.vscode").type_to_filetypes
vscode_filetypes["node"] = js_filetypes
vscode_filetypes["pwa-node"] = js_filetypes
end,
}, |
2455166 to
c29c347
Compare
Closes #1501
📑 Description
This should be done after #1502 and #1503. I merged
dap.lua, since now theinit.luafile is smaller and more managable.I noticed that yioneko/nvim-vtsls is used, but I'm not sure if it was configured properly or not to use custom commands. Maybe those needs to be assigned to some keys.
Need to check if there are any other packs (angular/vue, etc) depend on this one.
astrocommunity/lua/astrocommunity/pack/angular/init.lua
Line 2 in b69674d
astrocommunity/lua/astrocommunity/pack/svelte/init.lua
Line 2 in b69674d
astrocommunity/lua/astrocommunity/pack/vue/init.lua
Line 2 in b69674d
astrocommunity/lua/astrocommunity/pack/astro/init.lua
Line 2 in b69674d
ℹ Additional Information
See previous issue #962 where discussion was about adding biome.js, maybe there are some relevant details there.