fix(kulala-nvim): resolve bugs in keymap setup and breaking lazy loading in general (#1567)

* fix(kulala-nvim): fix lazy loading issue with definition of `on_attach` function

* fix(kulala-nvim): fix incorrect usage of astrocore setup function

* fix(kulala-nvim): properly setup `keys` function to not be hard coded

Author: mehalter

lua/astrocommunity/programming-language-support/kulala-nvim/init.lua

@@ -1,9 +1,12 @@
 return {
   "mistweaverco/kulala.nvim",
   ft = { "http", "rest" },
-  keys = {
-    { "<leader>r", desc = "KulalaNvim" },
-  },
+  keys = function(_, keys)
+    local plugin = require("lazy.core.config").spec.plugins["kulala.nvim"]
+    local opts = require("lazy.core.plugin").values(plugin, "opts", false) -- resolve mini.clue options
+    if opts.global_keymaps_prefix then table.insert(keys, { opts.global_keymaps_prefix, desc = "Load KulalaNvim" }) end
+    return keys
+  end,
   dependencies = {
     {
       "nvim-treesitter/nvim-treesitter",
@@ -24,16 +27,16 @@ return {
   opts = {
     global_keymaps = true,
     global_keymaps_prefix = "<leader>r",
-    lsp = { on_attach = require("astrolsp").on_attach },
+    lsp = { on_attach = function(...) return require("astrolsp").on_attach(...) end },
   },
   config = function(_, opts)
     require("kulala").setup(opts)
-    require("astrocore").setup {
-      mappings = {
+    if opts.global_keymaps_prefix then
+      require("astrocore").set_mappings {
         n = {
           [opts.global_keymaps_prefix] = { desc = require("astroui").get_icon("KulalaNvim", 1, true) .. "KulalaNvim" },
         },
-      },
-    }
+      }
+    end
   end,
 }